From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Date: Tue, 29 Aug 2017 21:50:17 -0400 Message-ID: <20170830015017.GA28668@holos.localdomain> References: <87ziakwifi.fsf@holos> <87val88l0d.fsf@users.sourceforge.net> <20170828031104.GA15524@holos.localdomain> <87shgb89q1.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Trace: blaine.gmane.org 1504057886 29606 195.159.176.226 (30 Aug 2017 01:51:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Aug 2017 01:51:26 +0000 (UTC) User-Agent: Mutt/1.8.3 (2017-05-23) Cc: 28257@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 30 03:51:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dms9q-0006n7-HP for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Aug 2017 03:51:06 +0200 Original-Received: from localhost ([::1]:47664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dms9x-0002gv-BC for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Aug 2017 21:51:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dms9r-0002gf-9A for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 21:51:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dms9m-00079T-DO for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 21:51:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dms9m-00079D-6o for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 21:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dms9l-0002ue-Sn for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 21:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2017 01:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28257-submit@debbugs.gnu.org id=B28257.150405782611152 (code B ref 28257); Wed, 30 Aug 2017 01:51:01 +0000 Original-Received: (at 28257) by debbugs.gnu.org; 30 Aug 2017 01:50:26 +0000 Original-Received: from localhost ([127.0.0.1]:33041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dms9B-0002to-Tm for submit@debbugs.gnu.org; Tue, 29 Aug 2017 21:50:26 -0400 Original-Received: from mail-qk0-f193.google.com ([209.85.220.193]:36157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dms9A-0002tc-Kt for 28257@debbugs.gnu.org; Tue, 29 Aug 2017 21:50:25 -0400 Original-Received: by mail-qk0-f193.google.com with SMTP id l65so4304739qkc.3 for <28257@debbugs.gnu.org>; Tue, 29 Aug 2017 18:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kJ7bX9fn/FTDVlV7WwrGlgnbwo7G3Hhcg/2PYvCpFS4=; b=vJL7OrtD5Nuh/qKz6JQV697fRgp4JW3sllvTeqYxPrf3WqpDzh2WTuev/cy5wg79uS Gdtxa2jkrZ55ediXn/fQuXnFNJlH57yPxiX22NMn5U6t81XEh4cRzLmQjfG3RAOHhmSE KU+lA6T74E4WhfMWdUf/q5O8EACQiZvI9aVp2J/vL11V526g4sNCGfM4ReC+OjN472+c YuyiZJ8BitfZ/UkyKTgzm9H13NiLY+Hki91MtqGaV0ztVPYMFKy84Mu0X0JSQpcv/uVO A5hEvlN1E6tDsEQTsA/Ha5gKjPJG0XTSY2CB/tMwGeEV916fKqiUTPZ1esby64NRYEwH bCpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kJ7bX9fn/FTDVlV7WwrGlgnbwo7G3Hhcg/2PYvCpFS4=; b=C3aXyVLG4Ol8FUb1Qrfxx7WaHbyhbmzHj00mZmbCCZnMw+MurANeh9tPgiE32QTRiP 0bKTV6bGBKs8IeXco04W5v7fqBRIukFRzIv/8FaSbCaq509U3wM3z9PGA4D/FK6Jc4/H 6Yzh2lfF/gPtu6kKQVDYu7MviWtSwLZIDG2marPbPkO4iUnlbcnmdSX4b9qzGJ3c/uyC 7H8bOejqgj/g5yvDsgn9nEIGf6GQPXfXGafKQet86boi2krt7CipfqPUwkmJNGLarlIi mPdgKhyxiTNfgB/FpRNKn9oHoMHyehSv0UJ6behLC0BpJD9UdkHdZl31uHBlXFngBI2G VGFw== X-Gm-Message-State: AHYfb5g26Q3yor9d52ERzjXJyLOal6hJvEyP4rD1h/6VvghJ9Nss3TF0 AH4JRJIzK7e7PqijkYywQw== X-Received: by 10.55.96.6 with SMTP id u6mr8044586qkb.106.1504057818832; Tue, 29 Aug 2017 18:50:18 -0700 (PDT) Original-Received: from holos.localdomain (pool-173-64-88-95.bltmmd.fios.verizon.net. [173.64.88.95]) by smtp.gmail.com with ESMTPSA id c13sm2908743qkj.73.2017.08.29.18.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Aug 2017 18:50:18 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 8C73F68E72; Tue, 29 Aug 2017 21:50:17 -0400 (EDT) Content-Disposition: inline In-Reply-To: <87shgb89q1.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136364 Archived-At: On 28/08/17 at 09:05pm, npostavs@users.sourceforge.net wrote: >Mark Oteiza writes: > >> If both the buffer mode's documentation function and the function in the >> default-value return non-nil at a point, execution stops at the >> :before-until function, analogous to run-hook-with-args-until-success. >> >> I want to see both results. See what eldoc-documentation-compose does. >> >> To do what is described above, not only does one have to write some >> wrapper function to advise eldoc-documentation-function buffer-locally, >> but also one has to hook into any/every mode that might add its own doc >> function. > >Ah, I think I understand now. The patch makes it easier to customize >the composition of all eldoc-documentation-functions at the cost of >making it more difficult for the individual mode to decide how its own >doc function will compose. Correct. > Could be a worthwhile tradeoff (especially >since there currently aren't any individual mode eldoc functions using >anything apart from :before-until, afaik); I'm on the fence about this. Not in emacs, at least. In elpa, ggtags uses :after-until. The only 3rd party packages--that I can think of right now--that implement eldoc functions just use setq-local (elpy and geiser).