From: Christian Garbs <mitch@cgarbs.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel
Date: Tue, 1 Aug 2017 23:20:52 +0200 [thread overview]
Message-ID: <20170801212052.lc64vzvuluglctqq@cgarbs.de> (raw)
In-Reply-To: <87379no75t.fsf@nicolasgoaziou.fr>
Hello and sorry for the wait!
On Sun, Jul 23, 2017 at 11:05:02AM +0200, Nicolas Goaziou wrote:
> Christian Garbs <mitch@mitch.h.shuttle.de> writes:
>
> > * ob-vala.el: Add support for the Vala language to Babel.
> > +(defvar org-babel-vala-compiler "valac"
> > + "Command used to compile a Vala source code file into an
> > +executable.")
>
> The first line of a docstring should be a full sentence.
>
> Also, shouldn't this be a defcustom?
Yes, it should.
Looking at the other defcustoms, is the current wording ok?
Or should it still be full a sentence?
> > +(defun org-babel-vala-table-or-string (results)
> > + "If the results look like a table, then convert them into an
> > +Emacs-lisp table, otherwise return the results as a string."
> > + )
>
> The body of the function is missing.
Not only is the body missing, the function is also not used at all, so
I have removed it altogether. Same for org-babel-vala-var-to-vala.
> Could you send an updated patch?
Incoming :-)
Some of your proposed changes apply to ob-C.el as well. I could
prepare a different patch for that (under which topic?), but I am not
confident that I could test the changes appropriately. I don't have
proper C/C++/D org files handy that would cover all cases (eg. header
arguments).
Regards
Christian
PS: My FSF paperwork is complete.
--
....Christian.Garbs....................................https://www.cgarbs.de
Wie packt man Styroporkügelchen ein, wenn man sie verschickt?
next prev parent reply other threads:[~2017-08-01 21:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 20:09 Babel support for Vala Christian Garbs
2017-07-10 9:03 ` Nicolas Goaziou
2017-07-10 17:54 ` Christian Garbs
2017-07-11 8:10 ` Nicolas Goaziou
2017-07-13 21:42 ` Christian Garbs
2017-07-14 8:30 ` Nicolas Goaziou
2017-07-14 19:43 ` [PATCH] ob-vala.el: Add Vala support to Babel Christian Garbs
2017-07-23 9:05 ` Nicolas Goaziou
2017-07-31 22:04 ` [PATCH v2] " Christian Garbs
2017-08-01 21:59 ` Nicolas Goaziou
2017-07-31 22:04 ` [PATCH v3] " Christian Garbs
2017-08-07 9:41 ` Nicolas Goaziou
2017-08-01 21:20 ` Christian Garbs [this message]
2017-08-01 22:03 ` [PATCH] " Nicolas Goaziou
2017-08-02 20:24 ` Christian Garbs
2017-08-03 10:49 ` Nicolas Goaziou
2017-08-05 19:53 ` Christian Garbs
2017-08-06 0:22 ` Nicolas Goaziou
2017-08-06 10:06 ` Christian Garbs
2017-08-07 9:52 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801212052.lc64vzvuluglctqq@cgarbs.de \
--to=mitch@cgarbs.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.