From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Date: Mon, 24 Jul 2017 20:31:43 -0400 Message-ID: <20170725003143.GA9855@holos.localdomain> References: <20170723194435.31877.401@vcs0.savannah.gnu.org> <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org> <20170725002528.GA9595@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Trace: blaine.gmane.org 1500942751 18769 195.159.176.226 (25 Jul 2017 00:32:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Jul 2017 00:32:31 +0000 (UTC) User-Agent: Mutt/1.8.3 (2017-05-23) Cc: Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 25 02:32:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZnlz-0004iv-3y for ged-emacs-devel@m.gmane.org; Tue, 25 Jul 2017 02:32:27 +0200 Original-Received: from localhost ([::1]:57757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZnm4-0001x0-NH for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 20:32:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZnlM-0001wu-KZ for emacs-devel@gnu.org; Mon, 24 Jul 2017 20:31:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZnlJ-00086Q-JH for emacs-devel@gnu.org; Mon, 24 Jul 2017 20:31:48 -0400 Original-Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:34316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZnlJ-000866-Fr for emacs-devel@gnu.org; Mon, 24 Jul 2017 20:31:45 -0400 Original-Received: by mail-qk0-x236.google.com with SMTP id t2so64907720qkc.1 for ; Mon, 24 Jul 2017 17:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=doc6OviQKgVG5t5jZGiLeL+g4zVn9Ul4J0zfHEkgmwk=; b=VHhGJ+CmG3rqcQFQih73+BRlNRmqmsPnHRAIRQcci+OLCBEynSCPFf+odLJ1ahPfDa 8UutjFTlSwQpr4S1odXtAgD1ZGbjmXukewTj1dD4V9o+hWE6/w64mfM3nTXD0gkazJa2 +IWExnTGLfAU10e5ZvFTJmeiMltsLUv1GWDcvcCU1TKNF+N1tEqTeVA7DPMDXtJn3BHq xh8+9xAYoZCSQyRCia2Xn/oE4hh/Fc4MyqoxDIFI3IZjax3M8Gd56cDMmbzZ7llgia03 9RzB/62LldpEMmGZiAjP2tTgoWE1akInrkqLsxqV+XUWwGZHKWFdVXXsbNGJ8E70KAVY I3BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=doc6OviQKgVG5t5jZGiLeL+g4zVn9Ul4J0zfHEkgmwk=; b=Gklig8zHMmY/oIJOOw1j1Is5U4uyDElf/xApl5X8WWAgLh+cZmPH5Cx0UeObdhQoQM SeVUZWXJRIfzmrov2FDuFzN0nS0W/RNPiF/pqeFlZ8sJPLTqykhSv3XWysNv8BZTDukD cDzlexM6J6tf6cxMfehrKm9Ra+1h+TPsyZAAGaPrp3LdzlfU1vK1AHk/+guafX+mDIew ePC7BMmh1ZbPD1oN0tlxf5Ak/er1/qWApOmNB7OpE9bKX3BtlIflKTX0QyY9+rfubrzH LHY43Jqw8CTtM95q29RnbZsoPd9O52/Nb0tLwjZQ/5lbzZhUbcwZCfqOX9QD7jcyYowm Stng== X-Gm-Message-State: AIVw112zTLn2gaHszoPdJ4ZPa5wAE6t4Bp7c8nUM5SreuiyHjSG+Qpk+ 7Vw2c9lEyoNha00a8DG2mw== X-Received: by 10.233.222.69 with SMTP id s66mr23027384qkf.30.1500942704718; Mon, 24 Jul 2017 17:31:44 -0700 (PDT) Original-Received: from holos.localdomain (pool-173-64-125-158.bltmmd.fios.verizon.net. [173.64.125.158]) by smtp.gmail.com with ESMTPSA id s2sm3683512qkl.84.2017.07.24.17.31.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jul 2017 17:31:43 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 7932F6BB97; Mon, 24 Jul 2017 20:31:43 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20170725002528.GA9595@holos.localdomain> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217005 Archived-At: On 24/07/17 at 08:25pm, Mark Oteiza wrote: >On 24/07/17 at 12:56pm, Glenn Morris wrote: >>Stefan Monnier wrote: >> >>>> ;;;###autoload >>>>+(defun turn-on-display-line-numbers-mode () >>>>+ "Turn on `display-line-numbers-mode'." >>>>+ (unless (or (minibufferp) >>>>+ ;; taken from linum.el >>>>+ (and (daemonp) (null (frame-parameter nil 'client)))) >>>>+ (display-line-numbers-mode))) >>> >>>Could you make it use the "display-line-numbers-" prefix? >>> >>And then it doesn't need to be autoloaded. > >Done in 32daa3cb, thanks. I know why I named it turn-on-foo, not sure >why I autoloaded it. Hmm, looking again--define-globalized-minor-mode mentions its TURN-ON function. Prefix-all-the-things aside, this looks weird to me for it to be an internal function.