all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument
Date: Mon, 24 Jul 2017 20:31:43 -0400	[thread overview]
Message-ID: <20170725003143.GA9855@holos.localdomain> (raw)
In-Reply-To: <20170725002528.GA9595@holos.localdomain>

On 24/07/17 at 08:25pm, Mark Oteiza wrote:
>On 24/07/17 at 12:56pm, Glenn Morris wrote:
>>Stefan Monnier wrote:
>>
>>>> ;;;###autoload
>>>>+(defun turn-on-display-line-numbers-mode ()
>>>>+  "Turn on `display-line-numbers-mode'."
>>>>+  (unless (or (minibufferp)
>>>>+              ;; taken from linum.el
>>>>+              (and (daemonp) (null (frame-parameter nil 'client))))
>>>>+    (display-line-numbers-mode)))
>>>
>>>Could you make it use the "display-line-numbers-" prefix?
>>>
>>And then it doesn't need to be autoloaded.
>
>Done in 32daa3cb, thanks.  I know why I named it turn-on-foo, not sure
>why I autoloaded it.

Hmm, looking again--define-globalized-minor-mode mentions its TURN-ON
function.  Prefix-all-the-things aside, this looks weird to me for it to
be an internal function.



      reply	other threads:[~2017-07-25  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170723194435.31877.401@vcs0.savannah.gnu.org>
     [not found] ` <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org>
2017-07-24 14:33   ` [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Stefan Monnier
2017-07-24 16:56     ` Glenn Morris
2017-07-25  0:25       ` Mark Oteiza
2017-07-25  0:31         ` Mark Oteiza [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725003143.GA9855@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.