From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Date: Mon, 24 Jul 2017 20:25:28 -0400 Message-ID: <20170725002528.GA9595@holos.localdomain> References: <20170723194435.31877.401@vcs0.savannah.gnu.org> <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Trace: blaine.gmane.org 1500942375 11710 195.159.176.226 (25 Jul 2017 00:26:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Jul 2017 00:26:15 +0000 (UTC) User-Agent: Mutt/1.8.3 (2017-05-23) Cc: Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 25 02:26:11 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZnfv-0002nS-Cp for ged-emacs-devel@m.gmane.org; Tue, 25 Jul 2017 02:26:11 +0200 Original-Received: from localhost ([::1]:57750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZnfy-000149-SD for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 20:26:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZnfM-000144-JJ for emacs-devel@gnu.org; Mon, 24 Jul 2017 20:25:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZnfJ-0005Bd-8S for emacs-devel@gnu.org; Mon, 24 Jul 2017 20:25:36 -0400 Original-Received: from mail-qt0-x236.google.com ([2607:f8b0:400d:c0d::236]:34495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZnfJ-0005BI-1o for emacs-devel@gnu.org; Mon, 24 Jul 2017 20:25:33 -0400 Original-Received: by mail-qt0-x236.google.com with SMTP id s6so30208836qtc.1 for ; Mon, 24 Jul 2017 17:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jBGQB5PseZy0XDrJQEg0PCmUX/qn+8rY4HKQPxQLHd4=; b=zlitpKPe5F9vhJfwezombScLR59hUnvXi1i+3zg47B+RiD2n/1bi/uKf9LGLQFQHTZ 81K8DtYYHefUicrbSnYezJSKMw5t5ZVHwb5MTJYftc1fwMcaR1osS83z+Ek1DSRSrQ4K ZhK4gJTJJxlO0Aidpkz0fUmLKlMVsUPAu94auplCg7fkNFfYIbtfzR3sCRx1/O8u/1Fc Fs4G+aCmecMFpPe6JMPEGFc0TFFhjtyExg5qBpzPsIbCBaYmfyHYTIeQU8maDmBHlDoJ cLwih8kqI9JiqT9yNaUMwjJokYkrGmOUzSRyoLxwj1qxjRmk/dV7/SSZBg+cJ2rXW26a o62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jBGQB5PseZy0XDrJQEg0PCmUX/qn+8rY4HKQPxQLHd4=; b=AYl+vWq6oWVJ27fr9RyJ6a6DKNzmInWUjktlb6800kh6pDT9tG0JQre9x+zrf1/fCq 1uNyZjiw19tb/MPECoJ7tHy6HiLGWaULC+uijp0IfM87qI7345hJRHYhCgbcA/SC5ILX 3fZuf/uRcY/WB7gk6pkl2keOto1muE+3Y5Iun5EEiKkp00IUlcdqA7FmnJ9eUJcrqhJd 3BBVfUNpBo/0V76itqaqah0j8QhiWTK1LqXOEGQ/LXtKcC4+/y4l7OKRMq7+KYDX2TsI sONUY2RMeOoqJ0Pbc111jyMWOe3Rvmbbb35Q+rHnTWUh3U6Ppj79BrRuKj/zPjBGGo8s XuZQ== X-Gm-Message-State: AIVw113QfzxfPUX0NU77CvXOSL6Fk1tt8ih8Z2iAiJg80MJcfpGKxXM/ Ld5NeOf+q8c/v1YhCB/v/g== X-Received: by 10.200.48.2 with SMTP id f2mr11491330qte.0.1500942330706; Mon, 24 Jul 2017 17:25:30 -0700 (PDT) Original-Received: from holos.localdomain (pool-173-64-125-158.bltmmd.fios.verizon.net. [173.64.125.158]) by smtp.gmail.com with ESMTPSA id i184sm7170296qkd.10.2017.07.24.17.25.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jul 2017 17:25:29 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 080016BB97; Mon, 24 Jul 2017 20:25:28 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217004 Archived-At: On 24/07/17 at 12:56pm, Glenn Morris wrote: >Stefan Monnier wrote: > >>> ;;;###autoload >>> +(defun turn-on-display-line-numbers-mode () >>> + "Turn on `display-line-numbers-mode'." >>> + (unless (or (minibufferp) >>> + ;; taken from linum.el >>> + (and (daemonp) (null (frame-parameter nil 'client)))) >>> + (display-line-numbers-mode))) >> >> Could you make it use the "display-line-numbers-" prefix? >> >And then it doesn't need to be autoloaded. Done in 32daa3cb, thanks. I know why I named it turn-on-foo, not sure why I autoloaded it.