all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument
       [not found] ` <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org>
@ 2017-07-24 14:33   ` Stefan Monnier
  2017-07-24 16:56     ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2017-07-24 14:33 UTC (permalink / raw)
  To: emacs-devel; +Cc: Mark Oteiza

>  ;;;###autoload
> +(defun turn-on-display-line-numbers-mode ()
> +  "Turn on `display-line-numbers-mode'."
> +  (unless (or (minibufferp)
> +              ;; taken from linum.el
> +              (and (daemonp) (null (frame-parameter nil 'client))))
> +    (display-line-numbers-mode)))

Could you make it use the "display-line-numbers-" prefix?


        Stefan "who'd also use a ¨--" since it's unlikely to be useful
                outside of the package"



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument
  2017-07-24 14:33   ` [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Stefan Monnier
@ 2017-07-24 16:56     ` Glenn Morris
  2017-07-25  0:25       ` Mark Oteiza
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2017-07-24 16:56 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Mark Oteiza, emacs-devel

Stefan Monnier wrote:

>>  ;;;###autoload
>> +(defun turn-on-display-line-numbers-mode ()
>> +  "Turn on `display-line-numbers-mode'."
>> +  (unless (or (minibufferp)
>> +              ;; taken from linum.el
>> +              (and (daemonp) (null (frame-parameter nil 'client))))
>> +    (display-line-numbers-mode)))
>
> Could you make it use the "display-line-numbers-" prefix?
>
>
>         Stefan "who'd also use a ¨--" since it's unlikely to be useful
>                 outside of the package"

And then it doesn't need to be autoloaded.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument
  2017-07-24 16:56     ` Glenn Morris
@ 2017-07-25  0:25       ` Mark Oteiza
  2017-07-25  0:31         ` Mark Oteiza
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Oteiza @ 2017-07-25  0:25 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Stefan Monnier, emacs-devel

On 24/07/17 at 12:56pm, Glenn Morris wrote:
>Stefan Monnier wrote:
>
>>>  ;;;###autoload
>>> +(defun turn-on-display-line-numbers-mode ()
>>> +  "Turn on `display-line-numbers-mode'."
>>> +  (unless (or (minibufferp)
>>> +              ;; taken from linum.el
>>> +              (and (daemonp) (null (frame-parameter nil 'client))))
>>> +    (display-line-numbers-mode)))
>>
>> Could you make it use the "display-line-numbers-" prefix?
>>
>And then it doesn't need to be autoloaded.

Done in 32daa3cb, thanks.  I know why I named it turn-on-foo, not sure
why I autoloaded it.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument
  2017-07-25  0:25       ` Mark Oteiza
@ 2017-07-25  0:31         ` Mark Oteiza
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Oteiza @ 2017-07-25  0:31 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Stefan Monnier, emacs-devel

On 24/07/17 at 08:25pm, Mark Oteiza wrote:
>On 24/07/17 at 12:56pm, Glenn Morris wrote:
>>Stefan Monnier wrote:
>>
>>>> ;;;###autoload
>>>>+(defun turn-on-display-line-numbers-mode ()
>>>>+  "Turn on `display-line-numbers-mode'."
>>>>+  (unless (or (minibufferp)
>>>>+              ;; taken from linum.el
>>>>+              (and (daemonp) (null (frame-parameter nil 'client))))
>>>>+    (display-line-numbers-mode)))
>>>
>>>Could you make it use the "display-line-numbers-" prefix?
>>>
>>And then it doesn't need to be autoloaded.
>
>Done in 32daa3cb, thanks.  I know why I named it turn-on-foo, not sure
>why I autoloaded it.

Hmm, looking again--define-globalized-minor-mode mentions its TURN-ON
function.  Prefix-all-the-things aside, this looks weird to me for it to
be an internal function.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-25  0:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170723194435.31877.401@vcs0.savannah.gnu.org>
     [not found] ` <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org>
2017-07-24 14:33   ` [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Stefan Monnier
2017-07-24 16:56     ` Glenn Morris
2017-07-25  0:25       ` Mark Oteiza
2017-07-25  0:31         ` Mark Oteiza

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.