From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
To: npostavs@users.sourceforge.net
Cc: tkk@misasa.okayama-u.ac.jp, monnier@iro.umontreal.ca,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569)
Date: Fri, 21 Jul 2017 13:11:54 +0900 (JST) [thread overview]
Message-ID: <20170721.131154.778619680886235556.tkk@misasa.okayama-u.ac.jp> (raw)
In-Reply-To: <CAM-tV-94CQLsJwVw7=yrz6CdCQy+OXBfEuHc3Noyi7_Y6MoC-w@mail.gmail.com>
>>> (define-key global-map [mouse-3]
>>> `(menu-item "Edit menu" my-edit-map
>>> :filter ,(lambda (_) (my-edit-map (aref (this-command-keys) 0)))))
>>> ;; delete-selection now works correctly with yank invoked via the mouse-3 menu
>>> (delete-selection-mode +1)
>>
>> I want to call flyspell-correct-word when word under event is
>> flyspell-incorrect (mouse-2 is too hard to access). When not, then
>> the dynamic edit menu.
>
> (defun my-edit-map (event)
> (if (get-text-property (posn-point (event-start event))
> 'flyspell-incorrect)
> #'flyspell-correct-word
> menu-bar-edit-menu))
>
> Just return the `flyspell-correct-word' symbol.
Now I got rid of usage of popup-menu in the code.
(defun my-edit-map (event)
(let ((faces-at-point (mapcar (lambda (xxx) (overlay-get xxx 'face))
(overlays-at (posn-point (event-start event))))))
(cond
((member 'flyspell-incorrect faces-at-point)
#'flyspell-correct-word)
(t
menu-bar-edit-menu))))
I confirmed that without the patch of menu-bar, yank via edit-menu
deletes region. Thank you for instructions.
CONCLUSION:
Your change is not needed.
next prev parent reply other threads:[~2017-07-21 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170718103950.22436.83344@vcs0.savannah.gnu.org>
[not found] ` <20170718103952.4E6F720E35@vcs0.savannah.gnu.org>
2017-07-18 13:41 ` [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) Stefan Monnier
2017-07-18 16:23 ` Noam Postavsky
2017-07-18 17:28 ` Stefan Monnier
2017-07-18 17:50 ` Noam Postavsky
2017-07-18 18:14 ` Stefan Monnier
2017-07-18 22:45 ` Noam Postavsky
2017-07-19 3:05 ` Stefan Monnier
2017-07-19 3:18 ` Tak Kunihiro
2017-07-19 11:26 ` Noam Postavsky
2017-07-20 0:14 ` Tak Kunihiro
2017-07-20 0:28 ` Noam Postavsky
2017-07-21 4:11 ` Tak Kunihiro [this message]
2017-07-20 1:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721.131154.778619680886235556.tkk@misasa.okayama-u.ac.jp \
--to=tkk@misasa.okayama-u.ac.jp \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.