From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tak Kunihiro Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) Date: Wed, 19 Jul 2017 12:18:17 +0900 (JST) Message-ID: <20170719.121817.1770061592165445558.tkk@misasa.okayama-u.ac.jp> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1500435658 15197 195.159.176.226 (19 Jul 2017 03:40:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Jul 2017 03:40:58 +0000 (UTC) Cc: tkk@misasa.okayama-u.ac.jp, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: npostavs@users.sourceforge.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 19 05:40:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXfqy-0003CV-9Z for ged-emacs-devel@m.gmane.org; Wed, 19 Jul 2017 05:40:48 +0200 Original-Received: from localhost ([::1]:59661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXfr0-0006OK-KB for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 23:40:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXfqN-0006OD-LM for emacs-devel@gnu.org; Tue, 18 Jul 2017 23:40:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXfqJ-0006AF-KS for emacs-devel@gnu.org; Tue, 18 Jul 2017 23:40:11 -0400 Original-Received: from mxl065v65.mxlogic.net ([208.81.65.65]:60264 helo=s14p02o142.mxlogic.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXfqJ-00067j-2Z for emacs-devel@gnu.org; Tue, 18 Jul 2017 23:40:07 -0400 Original-Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s14p02o142.mxlogic.net(mxl_mta-8.5.0-1834) with ESMTP id 694de695.7fc8f43d9700.232315.00-550.502750.s14p02o142.mxlogic.net (envelope-from ); Tue, 18 Jul 2017 21:40:06 -0600 (MDT) X-MXL-Hash: 596ed4961a64f614-e0af8412049913659b9a6c6476918223300eb290 Original-Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s14p02o142.mxlogic.net(mxl_mta-8.5.0-1834) over TLS secured channel with ESMTP id ccfce695.0.231720.00-368.501237.s14p02o142.mxlogic.net (envelope-from ); Tue, 18 Jul 2017 21:19:43 -0600 (MDT) X-MXL-Hash: 596ecfcf34acf0bf-1b3b95de016f431406cbcf33669c3910ff573be2 Original-Received: from alml002.ouadm.okayama-u.ac.jp (unknown [42.127.236.168]) by mlsec.cc.okayama-u.ac.jp with smtp id 0a38_7635_3311ac61_6b05_4ef5_9fb4_562f34e7483e; Wed, 19 Jul 2017 12:19:36 +0900 Original-Received: from localhost (unknown [172.24.1.69]) by alml002.ouadm.okayama-u.ac.jp (Postfix) with ESMTPSA id 57D874C0A24; Wed, 19 Jul 2017 12:19:36 +0900 (JST) In-Reply-To: X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 11 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 4 Rules triggered EDT_SA_AU_PASS=0, EDT_SA_DN_PASS=0, EDT_SA_TS_PASS=0, RV6074=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6074> : inlines <5981> : streams <1754803> : uri <2465652> X-AnalysisOut: [v=2.2 cv=ebZNR/MH c=1 sm=1 tr=0 a=8LLPK8U+aGQ6qN8QlyMYtQ==] X-AnalysisOut: [:117 a=8LLPK8U+aGQ6qN8QlyMYtQ==:17 a=kj9zAlcOel0A:10 a=G3g] X-AnalysisOut: [G6ho9WtcA:10 a=4YBRgYHtKwu0p4J8ofEA:9 a=7Zwj6sZBwVKJAoWSPK] X-AnalysisOut: [xL6X1jA+E=:19 a=CjuIK1q_8ugA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2017071814); S=0.408(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [42.127.236.175] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 208.81.65.65 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216871 Archived-At: > menu-bar-edit-menu > :filter ,(lambda (_) menu-bar-edit-menu))) > ;; delete-selection now works correctly with yank invoked via the mouse-3 menu > (delete-selection-mode +1) > > So perhaps my change to popup-menu isn't really needed... I want to construct edit-menu dynamically depending on event. Using the technique, code will look: (define-key global-map [mouse-3] (lambda (event) (interactive "e") (let ((my-edit-map (my-edit-map event))) `(menu-item "Edit menu" my-edit-map :filter ,(lambda (_) my-edit-map))))) ;; delete-selection now works correctly with yank invoked via the mouse-3 menu (delete-selection-mode +1) (defun my-edit-map (start-event) ; ... menu-bar-edit-menu) CONCLUSION: I appreciate your change and I think it is needed.