Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent.

Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent.

[Stefan Monnier]

> +(defmacro c-set-keymap-parent (map parent)
> +  (cond
> +   ;; XEmacs
> +   ((cc-bytecomp-fboundp 'set-keymap-parents)
> +    `(set-keymap-parents ,map ,parent))
> +   ;; Emacs
> +   ((cc-bytecomp-fboundp 'set-keymap-parent)
> +    `(set-keymap-parent ,map ,parent))
> +   ;; incompatible
> +   (t (error "CC Mode is incompatible with this version of Emacs"))))

All versions of Emacs I can think of have `set-keymap-parent`, including
Emacs-19 and XEmacs.  Why not just always use `set-keymap-parent`?


        Stefan

Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent.

[Alan Mackenzie]

Hello, Stefan.

On Wed, Jul 12, 2017 at 14:10:56 -0400, Stefan Monnier wrote:
> > +(defmacro c-set-keymap-parent (map parent)
> > +  (cond
> > +   ;; XEmacs
> > +   ((cc-bytecomp-fboundp 'set-keymap-parents)
> > +    `(set-keymap-parents ,map ,parent))
> > +   ;; Emacs
> > +   ((cc-bytecomp-fboundp 'set-keymap-parent)
> > +    `(set-keymap-parent ,map ,parent))
> > +   ;; incompatible
> > +   (t (error "CC Mode is incompatible with this version of Emacs"))))

> All versions of Emacs I can think of have `set-keymap-parent`, including
> Emacs-19 and XEmacs.  Why not just always use `set-keymap-parent`?

Why not, indeed?  I wasn't aware of the existence of `set-keymap-parent'
in XEmacs until you pointed it out.  The preferred form in XEmacs is in
any case `set-keymap-parents', the singular form being in a file called
"obsolete.el".

Anyway, it doesn't seem to be a big enough point to be worth raising a
fuss over. 

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).