From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent.
Date: Thu, 13 Jul 2017 18:00:11 +0000 [thread overview]
Message-ID: <20170713180011.GA2321@acm> (raw)
In-Reply-To: <jwv7ezdjzr2.fsf-monnier+emacsdiffs@gnu.org>
Hello, Stefan.
On Wed, Jul 12, 2017 at 14:10:56 -0400, Stefan Monnier wrote:
> > +(defmacro c-set-keymap-parent (map parent)
> > + (cond
> > + ;; XEmacs
> > + ((cc-bytecomp-fboundp 'set-keymap-parents)
> > + `(set-keymap-parents ,map ,parent))
> > + ;; Emacs
> > + ((cc-bytecomp-fboundp 'set-keymap-parent)
> > + `(set-keymap-parent ,map ,parent))
> > + ;; incompatible
> > + (t (error "CC Mode is incompatible with this version of Emacs"))))
> All versions of Emacs I can think of have `set-keymap-parent`, including
> Emacs-19 and XEmacs. Why not just always use `set-keymap-parent`?
Why not, indeed? I wasn't aware of the existence of `set-keymap-parent'
in XEmacs until you pointed it out. The preferred form in XEmacs is in
any case `set-keymap-parents', the singular form being in a file called
"obsolete.el".
Anyway, it doesn't seem to be a big enough point to be worth raising a
fuss over.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
prev parent reply other threads:[~2017-07-13 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170712170703.22088.69111@vcs0.savannah.gnu.org>
[not found] ` <20170712170705.8D71A22E12@vcs0.savannah.gnu.org>
2017-07-12 18:10 ` [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent Stefan Monnier
2017-07-13 18:00 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713180011.GA2321@acm \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.