From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Date: Wed, 12 Jul 2017 17:50:03 +0000 Message-ID: <20170712175003.GA13295@acm> References: <2136449839.36363.1493146365820@office.mailbox.org> <20170427193636.GA2683@acm> <20170502211714.GB717@odonien.localdomain> <20170507112229.GA22721@acm.fritz.box> <20170507135834.GB645@odonien.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1499881939 7560 195.159.176.226 (12 Jul 2017 17:52:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Jul 2017 17:52:19 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 26658-done@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 12 19:52:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVLo1-0001Sg-3d for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jul 2017 19:52:09 +0200 Original-Received: from localhost ([::1]:55050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVLo6-0002ri-8F for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jul 2017 13:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVLnz-0002pW-4g for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2017 13:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVLnu-0000Yb-8X for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2017 13:52:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVLnu-0000YU-3u; Wed, 12 Jul 2017 13:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dVLnt-00024D-Uh; Wed, 12 Jul 2017 13:52:01 -0400 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 12 Jul 2017 17:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26658 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Mail-Followup-To: 26658@debbugs.gnu.org, acm@muc.de, mail@vasilij.de Original-Received: via spool by 26658-done@debbugs.gnu.org id=D26658.14998818857902 (code D ref 26658); Wed, 12 Jul 2017 17:52:01 +0000 Original-Received: (at 26658-done) by debbugs.gnu.org; 12 Jul 2017 17:51:25 +0000 Original-Received: from localhost ([127.0.0.1]:35730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVLnJ-00023N-FX for submit@debbugs.gnu.org; Wed, 12 Jul 2017 13:51:25 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:42223 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1dVLnH-00023E-DM for 26658-done@debbugs.gnu.org; Wed, 12 Jul 2017 13:51:23 -0400 Original-Received: (qmail 21802 invoked by uid 3782); 12 Jul 2017 17:51:21 -0000 Original-Received: from acm.muc.de (p548C6B90.dip0.t-ipconnect.de [84.140.107.144]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 12 Jul 2017 19:51:21 +0200 Original-Received: (qmail 13887 invoked by uid 1000); 12 Jul 2017 17:50:03 -0000 Content-Disposition: inline In-Reply-To: <20170507135834.GB645@odonien.localdomain> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134474 Archived-At: Hello, Vasilij. On Sun, May 07, 2017 at 15:58:34 +0200, Vasilij Schneidermann wrote: [ .... ] > > Do you have commit access to the Emacs repository? > No and I doubt I'll ever get it because I don't understand the commit > message rules at all. They appear to be loosely based upon GNU > changelog guidelines, but with everyone I send patches to interpreting > them differently, probably because there isn't much substance to them in > the first place. I've resorted to using M-x add-change-log-entry, > copying the result into the commit message and adjusting it describing > my changes, but there's apparently more to it than that. I've committed your patch, slightly altered, and am closing the bug. I suspect that the commit message I used will be yet another variant. ;-( Thanks again for that patch. > Anyway, here's an updated patch. > >>From 1e4a92e05b78edb2f58c138aa7792d39a6d9a9cb Mon Sep 17 00:00:00 2001 > From: Vasilij Schneidermann > Date: Sun, 7 May 2017 15:55:49 +0200 > Subject: [PATCH] Make prog-mode-map the parent of c-mode-base-map > Fixes #26658. > * lisp/progmodes/cc-mode.el (c-mode-base-map): Make prog-mode-map the > parent of c-mode-map if possible. > --- > lisp/progmodes/cc-mode.el | 3 +++ > 1 file changed, 3 insertions(+) > diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el > index 20c63d4dbe..8f9e40bb0d 100644 > --- a/lisp/progmodes/cc-mode.el > +++ b/lisp/progmodes/cc-mode.el > @@ -276,6 +276,9 @@ c-bind-special-erase-keys > nil > (setq c-mode-base-map (make-sparse-keymap)) > + (when (and (cc-bytecomp-fboundp 'set-keymap-parent) > + (boundp 'prog-mode-map)) > + (set-keymap-parent c-mode-base-map prog-mode-map)) > ;; Separate M-BS from C-M-h. The former should remain > ;; backward-kill-word. > -- > 2.12.2 -- Alan Mackenzie (Nuremberg, Germany).