From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pierre Lorenzon Newsgroups: gmane.emacs.help Subject: dired-make-relative-symlink Date: Tue, 04 Jul 2017 16:10:38 +0200 (CEST) Message-ID: <20170704.161038.773751553356814485.devel@pollock-nageoire.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1499178633 23926 195.159.176.226 (4 Jul 2017 14:30:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 14:30:33 +0000 (UTC) Cc: help-gnu-emacs@gnu.org To: rfrancoise@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Jul 04 16:30:27 2017 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSOqM-0005m1-Lh for geh-help-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 16:30:22 +0200 Original-Received: from localhost ([::1]:41705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSOqS-00006X-0l for geh-help-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 10:30:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSOq3-00006B-8A for help-gnu-emacs@gnu.org; Tue, 04 Jul 2017 10:30:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSOpx-00089T-EP for help-gnu-emacs@gnu.org; Tue, 04 Jul 2017 10:30:03 -0400 Original-Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:36858 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSOpx-00085g-3w for help-gnu-emacs@gnu.org; Tue, 04 Jul 2017 10:29:57 -0400 Original-Received: from localhost ([90.92.44.219]) by mwinf5d77 with ME id geVr1v00G4jjhYA03eVrv8; Tue, 04 Jul 2017 16:29:53 +0200 X-ME-Helo: localhost X-ME-Date: Tue, 04 Jul 2017 16:29:53 +0200 X-ME-IP: 90.92.44.219 X-Mailer: Mew version 6.7 on Emacs 26.0.50 / Mule 6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 80.12.242.123 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:113694 Archived-At: Hi, I wonder why the function dired-make-relative-symlink recalculate the relative name of the file instead of using file-relative-name of the files.el library. Making a few tests it seems that both codes produce the same result. Anyway maybe these tests are not torturing the code enough. files.el library seems to be very old and it looks strange to me that when dired-x.el was developped files.el was not known. I did not report that as a bug since it is not a bug but I think that a system is more maintainable when code is not duplicated. Regards PS/ Sory if I did not notice an evident reason for which the code is so !