From: Alan Mackenzie <acm@muc.de>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Fix to handling of C++ digit separators, improvements in handling of single quotes.
Date: Sun, 2 Jul 2017 06:03:37 +0000 [thread overview]
Message-ID: <20170702060337.GA2439@acm> (raw)
In-Reply-To: <CAM-tV-9vsF7NsOO-6cLtg0VmJ7Cmkd-SibztanJkRHYDoCRxDQ@mail.gmail.com>
Hello, Noam.
On Sat, Jul 01, 2017 at 23:35:41 -0400, Noam Postavsky wrote:
> On Sat, Jul 1, 2017 at 12:10 PM, Alan Mackenzie <acm@muc.de> wrote:
> > The code involved is moderately involved, with special cases needed to
> > handle things like '\'', '\\', or char foo [] = {',',',',',',','};. So
> > if there are any problems with it (in particular, large areas of text
> > following a quotey bit getting misfontified with font-lock-string-face),
> > please let me know.
> I think this change breaks tests/lisp/electric-tests.el, here's a
> reduced test case (backtrace attached)
> (with-temp-buffer
> (c++-mode)
> (insert " (((()) ")
> (goto-char 4)
> (insert ")"))
Yes. Sorry about that.
The problem is in c-quoted-number-head-before-point, where I've used
(match-beginning 0) without first checking that a search was successful.
In effect, I was using an uninitialised variable.
I'll fix it later on today, when I've got a clearer head and plenty of
time.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-07-02 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 16:10 Fix to handling of C++ digit separators, improvements in handling of single quotes Alan Mackenzie
2017-07-02 3:35 ` Noam Postavsky
2017-07-02 6:03 ` Alan Mackenzie [this message]
2017-07-02 13:05 ` Alan Mackenzie
2017-07-02 15:47 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170702060337.GA2439@acm \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.