From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master Date: Sun, 25 Jun 2017 14:13:01 +0000 Message-ID: <20170625141300.GA17130__19964.8691261702$1498400131$gmane$org@acm> References: <87zid1ho6b.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1498400131 29726 195.159.176.226 (25 Jun 2017 14:15:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Jun 2017 14:15:31 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 27436@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 25 16:15:27 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8Ju-0007Kd-Pq for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jun 2017 16:15:22 +0200 Original-Received: from localhost ([::1]:42755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP8Jz-0002zG-P8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jun 2017 10:15:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP8Jf-0002ni-Uk for bug-gnu-emacs@gnu.org; Sun, 25 Jun 2017 10:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP8Jf-0005eP-3v for bug-gnu-emacs@gnu.org; Sun, 25 Jun 2017 10:15:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dP8Jb-0005aj-Ci; Sun, 25 Jun 2017 10:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dP8Jb-0006sc-6Y; Sun, 25 Jun 2017 10:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 25 Jun 2017 14:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27436 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 27436-submit@debbugs.gnu.org id=B27436.149840005226343 (code B ref 27436); Sun, 25 Jun 2017 14:15:03 +0000 Original-Received: (at 27436) by debbugs.gnu.org; 25 Jun 2017 14:14:12 +0000 Original-Received: from localhost ([127.0.0.1]:37388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8Im-0006qp-Dl for submit@debbugs.gnu.org; Sun, 25 Jun 2017 10:14:12 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:27184 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1dP8Ik-0006qe-UW for 27436@debbugs.gnu.org; Sun, 25 Jun 2017 10:14:11 -0400 Original-Received: (qmail 21970 invoked by uid 3782); 25 Jun 2017 14:14:09 -0000 Original-Received: from acm.muc.de (p548C6540.dip0.t-ipconnect.de [84.140.101.64]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 25 Jun 2017 16:14:08 +0200 Original-Received: (qmail 17173 invoked by uid 1000); 25 Jun 2017 14:13:01 -0000 Content-Disposition: inline In-Reply-To: <87zid1ho6b.fsf@lylat> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133871 Archived-At: Hello, Alex. On Wed, Jun 21, 2017 at 00:04:12 -0600, Alex wrote: > cc-defs has this condition to check whether or not to include cl-lib: > ====================================== > (and (fboundp 'mapcan) > (subrp (symbol-function 'mapcan))) > ====================================== > As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns > true. Yes. Thanks for taking the trouble to report this bug. I've committed a fix to master. I'd be grateful if you would confirm it fixes the problem properly, or tell me what's not quite right. > Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why > it can't be used here? CC Mode has always favoured testing features rather than version numbers and the the base (X)Emacs, so that if a tested feature becomes or ceases to be available, CC Mode should pick that up automatically. That is illustrated by the current case, just that here the actual test used was suboptimal. Hopefully it is now OK. -- Alan Mackenzie (Nuremberg, Germany).