all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Alex <agrambot@gmail.com>
Cc: 27436@debbugs.gnu.org
Subject: bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master
Date: Sun, 25 Jun 2017 14:13:01 +0000	[thread overview]
Message-ID: <20170625141300.GA17130__19964.8691261702$1498400131$gmane$org@acm> (raw)
In-Reply-To: <87zid1ho6b.fsf@lylat>

Hello, Alex.

On Wed, Jun 21, 2017 at 00:04:12 -0600, Alex wrote:
> cc-defs has this condition to check whether or not to include cl-lib:

> ======================================
> (and (fboundp 'mapcan)
>      (subrp (symbol-function 'mapcan)))
> ======================================

> As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
> true.

Yes.  Thanks for taking the trouble to report this bug.

I've committed a fix to master.  I'd be grateful if you would confirm it
fixes the problem properly, or tell me what's not quite right.

> Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
> it can't be used here?

CC Mode has always favoured testing features rather than version numbers
and the the base (X)Emacs, so that if a tested feature becomes or ceases
to be available, CC Mode should pick that up automatically.  That is
illustrated by the current case, just that here the actual test used was
suboptimal.  Hopefully it is now OK.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2017-06-25 14:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  6:04 bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master Alex
2017-06-25 14:13 ` Alan Mackenzie [this message]
     [not found] ` <20170625141300.GA17130@acm>
2017-06-25 19:51   ` Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20170625141300.GA17130__19964.8691261702$1498400131$gmane$org@acm' \
    --to=acm@muc.de \
    --cc=27436@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.