From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pierre Neidhardt Newsgroups: gmane.emacs.bugs Subject: bug#27405: 25.2; Make eshell-next-prompt more reliable Date: Sun, 18 Jun 2017 15:19:59 +0100 Message-ID: <20170618141959.GB2617@gmail.com> References: <20170617090813.GA889@gmail.com> <87zid6qn3b.fsf@users.sourceforge.net> <20170618132932.GA2617@gmail.com> <87vantqu7m.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1497795673 28248 195.159.176.226 (18 Jun 2017 14:21:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Jun 2017 14:21:13 +0000 (UTC) User-Agent: Mutt/1.8.3 (2017-05-23) Cc: 27405@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 18 16:21:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMb4c-0006wZ-Ge for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jun 2017 16:21:06 +0200 Original-Received: from localhost ([::1]:38528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMb4h-0001U6-L9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jun 2017 10:21:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMb4b-0001Tq-6M for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 10:21:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMb4Y-0003Pw-1j for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 10:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMb4X-0003PZ-Sl for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 10:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMb4X-0005Z0-MT for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2017 10:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2017 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 27405-submit@debbugs.gnu.org id=B27405.149779560921310 (code B ref 27405); Sun, 18 Jun 2017 14:21:01 +0000 Original-Received: (at 27405) by debbugs.gnu.org; 18 Jun 2017 14:20:09 +0000 Original-Received: from localhost ([127.0.0.1]:55240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMb3g-0005Xe-Uh for submit@debbugs.gnu.org; Sun, 18 Jun 2017 10:20:09 -0400 Original-Received: from mail-wr0-f182.google.com ([209.85.128.182]:33837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMb3e-0005XB-VB for 27405@debbugs.gnu.org; Sun, 18 Jun 2017 10:20:07 -0400 Original-Received: by mail-wr0-f182.google.com with SMTP id 77so59244087wrb.1 for <27405@debbugs.gnu.org>; Sun, 18 Jun 2017 07:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Dxb1VkVn/MCWTRSWnanzvY1KDloBOtL88kuzDpQ+m3E=; b=HTbv2mT+SdEan4tQrTeNDlde7U7SUdB4k5uPfS6pWFLUVSzD5UGXXOIwK9wjs3dXF0 7TFaYkp76ivQB3gRlcGswCSwUMFDmpHw+ApSez1wwiNEZXMYH0RBLeJgY1tIDZd6P175 hdq9uuecJwRzZpisR4SrWR1yrPEnxEUjA6LIo5QQIQ1ACfnJRR+9AsvDrQFHnwJiJcdq 5I64DokC+WcN/Y76gWR8BbR868JEPFD5kkVI/n4wSiqoBzI8yXq+dvYDfTFuwPFZhIf0 4iu8MeB10SQqbsCyzhGYU8MZhMrVrMTAb0ZCH/5ClqmK/oQjWAebRFr5Cw6ZSlbHfVkB H2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Dxb1VkVn/MCWTRSWnanzvY1KDloBOtL88kuzDpQ+m3E=; b=o8Ox/HJU4Lce+c4C+c7Cq1zDusvgKkKa3cieRhQxDTxL6FTY7g9y1cpxlM6gYeKKs7 lWV2pI93HW3uWsqLQ5vJWXl4sJEoF8wUzycfzZA3QppSH8TqYgVZcYWrXU2jj/ADQYK+ OM13o+fcBkcZSL2R7m8mt5c5JO2ldhQmgvyCzAX0aN4N2fOPOFgI6H2c/GFZob4ZZEv0 Y0t8m2SWVFixOIWD5zCmnlC49CUqlilr3gdNzBjckA/2InUrEf3oiPGwg5TOle2OcmbA 6yzKeYocVZWIWFBvsrijynGEPoXsjj8E+2KQxGvSl9/fJXKKxBg7O66qrQLmQWVQxHDN LWYg== X-Gm-Message-State: AKS2vOxi9pw0O2bhdNwtIAgR8la+4Z/7YUSgZRpGVivEHle3pGr+15T8 03JhHi+E6kdNzg== X-Received: by 10.223.174.237 with SMTP id y100mr3554760wrc.2.1497795601293; Sun, 18 Jun 2017 07:20:01 -0700 (PDT) Original-Received: from gmail.com ([196.203.31.130]) by smtp.gmail.com with ESMTPSA id l6sm690345wmg.31.2017.06.18.07.20.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 07:20:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87vantqu7m.fsf@users.sourceforge.net> X-Info: Simplicity is the ultimate sophistication. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133730 Archived-At: On 17-06-18 09:52:13, npostavs@users.sourceforge.net wrote: > Pierre Neidhardt writes: > > >> > (defun eshell-previous-prompt (n) > >> > "Move to end of Nth previous prompt in the buffer. > >> > See `eshell-prompt-regexp'." > >> > (interactive "p") > >> > (backward-char) > >> > (eshell-next-prompt (- n)))) > >> > >> What's the backward-char for? > > > > That would have definitely deserved a comment... > > > > Without it, if point is right after the prompt, it won't move. That would be > > disturbing for the user. > > Hmm, maybe beginning-of-line would make more sense? If I have point on > the same line of the prompt I can get to the beginning of the prompted > line with C-a, so C-c C-p probably means I want to go farther back. Agreed. Please make the change and add a comment. -- Pierre Neidhardt