all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#27111: mode-line-position is faulty after b0b02ca7
@ 2017-05-28  4:35 Alex
  2017-05-28 14:59 ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Alex @ 2017-05-28  4:35 UTC (permalink / raw)
  To: 27111; +Cc: Alan Mackenzie

Start from emacs -Q:

Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

Click on the 'All' in the mode-line. Emacs does not show the menu.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#27111: mode-line-position is faulty after b0b02ca7
  2017-05-28  4:35 bug#27111: mode-line-position is faulty after b0b02ca7 Alex
@ 2017-05-28 14:59 ` Eli Zaretskii
  2017-05-29 17:35   ` Alan Mackenzie
  2017-05-29 20:35   ` Alan Mackenzie
  0 siblings, 2 replies; 7+ messages in thread
From: Eli Zaretskii @ 2017-05-28 14:59 UTC (permalink / raw)
  To: Alex; +Cc: acm, 27111

> From: Alex <agrambot@gmail.com>
> Date: Sat, 27 May 2017 22:35:12 -0600
> Cc: Alan Mackenzie <acm@muc.de>
> 
> Start from emacs -Q:
> 
> Hover over the 'All' in the mode-line. Emacs does not show the tooltip.
> 
> Click on the 'All' in the mode-line. Emacs does not show the menu.

Not just "All" -- any location indication is no longer
mouse-sensitive.

Alan, could you please take a look?





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#27111: mode-line-position is faulty after b0b02ca7
  2017-05-28 14:59 ` Eli Zaretskii
@ 2017-05-29 17:35   ` Alan Mackenzie
  2017-05-29 18:50     ` Eli Zaretskii
  2017-05-29 20:35   ` Alan Mackenzie
  1 sibling, 1 reply; 7+ messages in thread
From: Alan Mackenzie @ 2017-05-29 17:35 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 27111, Alex

Hello, Eli.

On Sun, May 28, 2017 at 17:59:05 +0300, Eli Zaretskii wrote:
> > From: Alex <agrambot@gmail.com>
> > Date: Sat, 27 May 2017 22:35:12 -0600
> > Cc: Alan Mackenzie <acm@muc.de>

> > Start from emacs -Q:

> > Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

> > Click on the 'All' in the mode-line. Emacs does not show the menu.

> Not just "All" -- any location indication is no longer
> mouse-sensitive.

> Alan, could you please take a look?

Yes, it's something causing text properties applied in the mode line
with :propertize either not to be applied, to be discarded, or to be
superseded by the mode line's default text properties.

I'll try and solve it properly in the next few days.

By the way, did you see my proposed patch to CC Mode which would allow
the user to switch between block comments and line comments?

-- 
Alan Mackenzie (Nuremberg, Germany).





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#27111: mode-line-position is faulty after b0b02ca7
  2017-05-29 17:35   ` Alan Mackenzie
@ 2017-05-29 18:50     ` Eli Zaretskii
  0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2017-05-29 18:50 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: 27111, agrambot

> Date: Mon, 29 May 2017 17:35:33 +0000
> Cc: Alex <agrambot@gmail.com>, 27111@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> > Not just "All" -- any location indication is no longer
> > mouse-sensitive.
> 
> > Alan, could you please take a look?
> 
> Yes, it's something causing text properties applied in the mode line
> with :propertize either not to be applied, to be discarded, or to be
> superseded by the mode line's default text properties.

If that's your problem, you should adhere religiously to the following
principle: make sure each string you put into some mode-line variable
has the same properties on all of its characters.

> By the way, did you see my proposed patch to CC Mode which would allow
> the user to switch between block comments and line comments?

Yes.  I'd like to hear more opinions about the issue raised by Stefan.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#27111: mode-line-position is faulty after b0b02ca7
  2017-05-28 14:59 ` Eli Zaretskii
  2017-05-29 17:35   ` Alan Mackenzie
@ 2017-05-29 20:35   ` Alan Mackenzie
  2017-05-30  4:03     ` Alex
  1 sibling, 1 reply; 7+ messages in thread
From: Alan Mackenzie @ 2017-05-29 20:35 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 27111, Alex

Hello, Alex and Eli.

On Sun, May 28, 2017 at 17:59:05 +0300, Eli Zaretskii wrote:
> > From: Alex <agrambot@gmail.com>
> > Date: Sat, 27 May 2017 22:35:12 -0600
> > Cc: Alan Mackenzie <acm@muc.de>

> > Start from emacs -Q:

> > Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

> > Click on the 'All' in the mode-line. Emacs does not show the menu.

> Not just "All" -- any location indication is no longer
> mouse-sensitive.

> Alan, could you please take a look?o

The problem was I had spuriously quoted elements inside a backquote
structure.  This should be fixed by the following patch.

Alex, just to emphasise, though it's probably not necessary to say,
you'll have to rebuild Emacs, properly to incorporate this patch, since
binding.elc is preloaded.  Please try out this patch and either confirm
to me it's fixed the bug, or tell me what's still wrong.  Thanks for
taking the trouble to report this bug, and thanks in advance for trying
out the patch.  :-)



diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0b4c3bda80..07f3441efd 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -382,14 +382,15 @@ mode-line-percent-position
                  (6 "%q")))
   :version "26.1"
   :group 'mode-line)
+(put 'mode-line-percent-position 'risky-local-variable t)
 
 (defvar mode-line-position
   `((:propertize
      mode-line-percent-position
-     'local-map mode-line-column-line-number-mode-map
-     'mouse-face 'mode-line-highlight
+     local-map ,mode-line-column-line-number-mode-map
+     mouse-face mode-line-highlight
      ;; XXX needs better description
-     'help-echo "Size indication mode\n\
+     help-echo "Size indication mode\n\
 mouse-1: Display Line and Column Mode Menu")
     (size-indication-mode
      (8 ,(propertize


-- 
Alan Mackenzie (Nuremberg, Germany).





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* bug#27111: mode-line-position is faulty after b0b02ca7
  2017-05-29 20:35   ` Alan Mackenzie
@ 2017-05-30  4:03     ` Alex
  2017-05-30 16:40       ` Alan Mackenzie
  0 siblings, 1 reply; 7+ messages in thread
From: Alex @ 2017-05-30  4:03 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: 27111

Alan Mackenzie <acm@muc.de> writes:

> Hello, Alex and Eli.
>
> The problem was I had spuriously quoted elements inside a backquote
> structure.  This should be fixed by the following patch.
>
> Alex, just to emphasise, though it's probably not necessary to say,
> you'll have to rebuild Emacs, properly to incorporate this patch, since
> binding.elc is preloaded.  Please try out this patch and either confirm
> to me it's fixed the bug, or tell me what's still wrong.  Thanks for
> taking the trouble to report this bug, and thanks in advance for trying
> out the patch.  :-)

It works, thanks.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#27111: mode-line-position is faulty after b0b02ca7
  2017-05-30  4:03     ` Alex
@ 2017-05-30 16:40       ` Alan Mackenzie
  0 siblings, 0 replies; 7+ messages in thread
From: Alan Mackenzie @ 2017-05-30 16:40 UTC (permalink / raw)
  To: Alex; +Cc: 27111-done

Hello, Alex.

On Mon, May 29, 2017 at 22:03:15 -0600, Alex wrote:
> Alan Mackenzie <acm@muc.de> writes:

[ .... ]

> It works, thanks.

OK, thanks.  I've committed the patch, and I'm closing the bug as fixed.

-- 
Alan Mackenzie (Nuremberg, Germany).





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-05-30 16:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-28  4:35 bug#27111: mode-line-position is faulty after b0b02ca7 Alex
2017-05-28 14:59 ` Eli Zaretskii
2017-05-29 17:35   ` Alan Mackenzie
2017-05-29 18:50     ` Eli Zaretskii
2017-05-29 20:35   ` Alan Mackenzie
2017-05-30  4:03     ` Alex
2017-05-30 16:40       ` Alan Mackenzie

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.