all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 27111@debbugs.gnu.org, Alex <agrambot@gmail.com>
Subject: bug#27111: mode-line-position is faulty after b0b02ca7
Date: Mon, 29 May 2017 20:35:56 +0000	[thread overview]
Message-ID: <20170529203556.GB2131@acm.fritz.box> (raw)
In-Reply-To: <83k251gh8m.fsf@gnu.org>

Hello, Alex and Eli.

On Sun, May 28, 2017 at 17:59:05 +0300, Eli Zaretskii wrote:
> > From: Alex <agrambot@gmail.com>
> > Date: Sat, 27 May 2017 22:35:12 -0600
> > Cc: Alan Mackenzie <acm@muc.de>

> > Start from emacs -Q:

> > Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

> > Click on the 'All' in the mode-line. Emacs does not show the menu.

> Not just "All" -- any location indication is no longer
> mouse-sensitive.

> Alan, could you please take a look?o

The problem was I had spuriously quoted elements inside a backquote
structure.  This should be fixed by the following patch.

Alex, just to emphasise, though it's probably not necessary to say,
you'll have to rebuild Emacs, properly to incorporate this patch, since
binding.elc is preloaded.  Please try out this patch and either confirm
to me it's fixed the bug, or tell me what's still wrong.  Thanks for
taking the trouble to report this bug, and thanks in advance for trying
out the patch.  :-)



diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0b4c3bda80..07f3441efd 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -382,14 +382,15 @@ mode-line-percent-position
                  (6 "%q")))
   :version "26.1"
   :group 'mode-line)
+(put 'mode-line-percent-position 'risky-local-variable t)
 
 (defvar mode-line-position
   `((:propertize
      mode-line-percent-position
-     'local-map mode-line-column-line-number-mode-map
-     'mouse-face 'mode-line-highlight
+     local-map ,mode-line-column-line-number-mode-map
+     mouse-face mode-line-highlight
      ;; XXX needs better description
-     'help-echo "Size indication mode\n\
+     help-echo "Size indication mode\n\
 mouse-1: Display Line and Column Mode Menu")
     (size-indication-mode
      (8 ,(propertize


-- 
Alan Mackenzie (Nuremberg, Germany).





  parent reply	other threads:[~2017-05-29 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28  4:35 bug#27111: mode-line-position is faulty after b0b02ca7 Alex
2017-05-28 14:59 ` Eli Zaretskii
2017-05-29 17:35   ` Alan Mackenzie
2017-05-29 18:50     ` Eli Zaretskii
2017-05-29 20:35   ` Alan Mackenzie [this message]
2017-05-30  4:03     ` Alex
2017-05-30 16:40       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529203556.GB2131@acm.fritz.box \
    --to=acm@muc.de \
    --cc=27111@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.