From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#27041: MacOS 10.6: fix NS build Date: Wed, 24 May 2017 20:03:34 +0100 Message-ID: <20170524190334.GA1018@breton.holly.idiocy.org> References: <20170523194947.GA59742@breton.holly.idiocy.org> <12b912c7-ef06-cbf1-d957-cc2f4cdac9fc@aurox.ch> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1495652658 26561 195.159.176.226 (24 May 2017 19:04:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 May 2017 19:04:18 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 27041-done@debbugs.gnu.org To: "Charles A. Roelli" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 24 21:04:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDbZp-0006hT-It for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 May 2017 21:04:11 +0200 Original-Received: from localhost ([::1]:56402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDbZv-00054B-0S for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 May 2017 15:04:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDbZn-0004wP-AI for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 15:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDbZi-0002j0-I7 for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 15:04:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33919) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDbZi-0002ir-CM for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 15:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dDbZi-0005Wc-15 for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 15:04:02 -0400 Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2017 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 27041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 27041@debbugs.gnu.org, alan@idiocy.org, charles@aurox.ch Original-Received: via spool by 27041-done@debbugs.gnu.org id=D27041.149565262621210 (code D ref 27041); Wed, 24 May 2017 19:04:01 +0000 Original-Received: (at 27041-done) by debbugs.gnu.org; 24 May 2017 19:03:46 +0000 Original-Received: from localhost ([127.0.0.1]:36596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDbZR-0005W1-Md for submit@debbugs.gnu.org; Wed, 24 May 2017 15:03:45 -0400 Original-Received: from mail-wr0-f169.google.com ([209.85.128.169]:33759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDbZQ-0005Vl-5D for 27041-done@debbugs.gnu.org; Wed, 24 May 2017 15:03:44 -0400 Original-Received: by mail-wr0-f169.google.com with SMTP id w50so60424240wrc.0 for <27041-done@debbugs.gnu.org>; Wed, 24 May 2017 12:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2mSPd3hqoD3z24b4lwNXguR79hVBbNXTRZBvLhcLvoQ=; b=F1rmvjw1/cMFbTXGo5/rvMzdAIk2NS1+UvrhtBogM10df3oxmGUgnjL1s1RvCG+ski SD64/i5myiTjGAn9NDW+fIkFe6y8TMn3bdfzeUz1YhqY5YQDBLoFvPuraNArCiqnRBQV VzJCLpwwTKUM3k3G52GgXrUt2RtPrfpknJ+kW5Nj9eYTngbFgxc0zyhmwzkCbPI8fyKS 1vFBNrR0gAX9wmQZuJHXb5ZGXTeCCTdUMZQySLkwA1hTDXY96gEfM+7zHcgGhqQkooVI qsRc7GbR4lTbgEf3wd/cmJlBZDURqqLxydwLe8cOmi/Smau6ZcIHW4KqhPu5WRB8/2GY U+wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=2mSPd3hqoD3z24b4lwNXguR79hVBbNXTRZBvLhcLvoQ=; b=kbBvcAa0o0TT13JMFd+OPDZvyFxBfe26nD2pKlAp8fkniglmj8RvRXIPSX9okNabxp 53DhoIydhtq8D9V7PXvTRfWVhvWwddwYB/cqb5E6mjERmMnNI+5HgI148yyXCKWMaIeH mmX9YSyFF3Rcj/gSdkzH9W3H/5aT6K0sLfa+GGmbH2x8j7R8g2gu5/roIOC9l1+1BXfQ vtpHwV8VGJa3easnXUZ0VmF73/gIz5/08zLFsHQgJAGmNbC5cnqtVGGjquicZ1D1hRxl b8XCA5YGKLJ6lUZ4b9wHjs5EVrVzpCkhh6Hu4ueWoiJakMTn0p3Mj8bDT64T5HNR1Vfk OTtg== X-Gm-Message-State: AODbwcAgniAs0lRnulvyHV380UldUCxPqzikr1zCyjGKW6GOla/GpNTy AKitLJ0IMB99QA== X-Received: by 10.223.142.50 with SMTP id n47mr20427802wrb.188.1495652617849; Wed, 24 May 2017 12:03:37 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-757d-ca29-5867-b957.holly.idiocy.org. [2001:8b0:3f8:8129:757d:ca29:5867:b957]) by smtp.gmail.com with ESMTPSA id w136sm3627315wmd.13.2017.05.24.12.03.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 12:03:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <12b912c7-ef06-cbf1-d957-cc2f4cdac9fc@aurox.ch> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132807 Archived-At: On Wed, May 24, 2017 at 08:13:21PM +0200, Charles A. Roelli wrote: > Thanks for your help. > > I changed the conditional to this: > > > #if defined(NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MAX_ALLOWED < > MAC_OS_X_VERSION_10_7 > typedef id instancetype; > typedef NSUInteger NSWindowStyleMask; > #endif > > > And it compiles fine without my previous changes. Can you verify that this > still builds with GNUstep? If not, we can leave the 'int' instead of the > 'NSUInteger'. It works fine on GNUstep too, so I’ve pushed the change. FWIW, that instancetype type appears to be a built‐in and we should probably be doing some sort of check whether the compiler supports it natively or not. I don’t know how to go about doing that. > > > I also see this warning when compiling macfont.m: > > > > > > macfont.m: In function ‘mac_font_shape_1’: > > > macfont.m:416: warning: ‘NSLayoutManager’ may not respond to > > > ‘-getGlyphsInRange:glyphs:properties:characterIndexes:bidiLevels:’ > > > macfont.m:416: warning: (Messages without a matching method signature > > > macfont.m:416: warning: will be assumed to return ‘id’ and accept > > > macfont.m:416: warning: ‘...’ as arguments.) > > > > > > (some new arguments were added in the recent changes). But this doesn't > > > seem to affect functionality so I've left that change as is. This warning doesn’t make much sense to me. I’ve looked up the documentation and the new method being used has allegedly been available since macOS 10.5. https://developer.apple.com/reference/appkit/nslayoutmanager/1403104-getglyphsinrange I guess if it’s working we can just ignore it. -- Alan Third