From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Perry E. Metzger" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Clean up a couple of compiler warnings Date: Sun, 21 May 2017 16:47:09 -0400 Message-ID: <20170521164709.7bfcaa11@jabberwock.cb.piermont.com> References: <20170518202450.75747-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1495399648 6317 195.159.176.226 (21 May 2017 20:47:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 May 2017 20:47:28 +0000 (UTC) Cc: Philipp Stephani , Paul Eggert , emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 21 22:47:20 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCXkw-0001HX-EQ for ged-emacs-devel@m.gmane.org; Sun, 21 May 2017 22:47:14 +0200 Original-Received: from localhost ([::1]:39253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCXl0-0004dn-86 for ged-emacs-devel@m.gmane.org; Sun, 21 May 2017 16:47:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCXku-0004cE-Kf for emacs-devel@gnu.org; Sun, 21 May 2017 16:47:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCXkt-0005jP-Qv for emacs-devel@gnu.org; Sun, 21 May 2017 16:47:12 -0400 Original-Received: from hacklheber.piermont.com ([2001:470:30:84:e276:63ff:fe62:3400]:47741) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dCXkt-0005j3-MU for emacs-devel@gnu.org; Sun, 21 May 2017 16:47:11 -0400 Original-Received: from snark.cb.piermont.com (localhost [127.0.0.1]) by hacklheber.piermont.com (Postfix) with ESMTP id 553733B5; Sun, 21 May 2017 16:47:10 -0400 (EDT) Original-Received: from jabberwock.cb.piermont.com (jabberwock.cb.piermont.com [10.160.2.107]) by snark.cb.piermont.com (Postfix) with ESMTP id 1C7962DE040; Sun, 21 May 2017 16:47:10 -0400 (EDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:470:30:84:e276:63ff:fe62:3400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215068 Archived-At: On Sun, 21 May 2017 20:00:11 +0000 Philipp Stephani wrote: > For Clang, it'd probably be better to use -Weverything and then > disable individual warnings with -Wno... instead of checking for > the existence of every warning flag. That would make configure runs > faster and the command line shorter. clang's -Weverything is like an options lamp test. There's an enormous number of things there, and many aren't even properly documented. You really don't want to use it -- the sheer number of things you'll need to disable is astonishing, and with every new iteration of clang there's an ocean more flags there. I think this solution should be avoided. Perry -- Perry E. Metzger perry@piermont.com