From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: SIGIO and the NS port Date: Sun, 21 May 2017 13:11:40 +0100 Message-ID: <20170521121140.GA28789@breton.holly.idiocy.org> References: <20170310124117.GA74077@breton.holly.idiocy.org> <20170313163817.GA40836@breton.holly.idiocy.org> <20170520232406.GA21521@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1495368740 14426 195.159.176.226 (21 May 2017 12:12:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 May 2017 12:12:20 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Emacs-Devel devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 21 14:12:16 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCPiZ-0003eL-Sj for ged-emacs-devel@m.gmane.org; Sun, 21 May 2017 14:12:16 +0200 Original-Received: from localhost ([::1]:37800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCPif-0001pl-BP for ged-emacs-devel@m.gmane.org; Sun, 21 May 2017 08:12:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCPi4-0001pV-0D for emacs-devel@gnu.org; Sun, 21 May 2017 08:11:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCPi3-0004xE-27 for emacs-devel@gnu.org; Sun, 21 May 2017 08:11:43 -0400 Original-Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCPi2-0004vm-RH for emacs-devel@gnu.org; Sun, 21 May 2017 08:11:42 -0400 Original-Received: by mail-wm0-x22c.google.com with SMTP id 7so35022555wmo.1 for ; Sun, 21 May 2017 05:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5H2DeqAE8TFOHQSj3Opued7KZdct/6ODhDidFMWxKC0=; b=qBzv9WGgKDaJ2woOEC/Y25X5YDmDdDrNw7JN0kwCvM4ctwdbuxDGmiuoVQ3OHihoZZ HDJ8wnGjLd/7mu7v+B8s3GOlpG8bwz7TxK6U0Oyv6fcn06e7PtdIaq6WbRiwVGeqaU0e a1XlHg5A44KifZ9APtRAkLFXeOoDg2ad8BNLLZuubLuTts6Sq53UAVEOi2HyaZQS+Su9 cXFybfV783Fy1T4wTEBihUeq5Qxf3a4gUjt7qdNBu66BZczIehjiPdz6P7mCb1cMwJH3 ZBe3BDdl19Cc6S0daGEhXrb64rm4ujk9SOgsd6OFo3uaBvLD5YSY/ZV5xSyuOcrn1aLs 2UyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=5H2DeqAE8TFOHQSj3Opued7KZdct/6ODhDidFMWxKC0=; b=OTMROLP26wY9EuXG28Q2bzFcqXScG6Q4JWTQ6B1kJutASFaKWvz43YQRYaV7kl9zhB ycQDWZSXA5r15BEC12cCeDBsofEocTH8hQZXRuW5emrB9oKweS3LF3mHsQ/2O4K7gHVP gFlxrL0u1c9zeCD5sozJec5ILVQm8gYN8Sbx8L59l8dLWGd0KpAbJ8V3ZNehUGh2T4TA qA4Z2jTmqJFIHDCIR7zh68Q31qQZ8rQtuBdvnZhspq+MjnjjPrIF4Mx+ZMMLQRb/zwIe XQACFsj5eAp1fDkOp1yAGtLgCL77Gw4/BOz5TtEwQCXH4KaS/mQJdl626f6xaj+e5a1k OD1w== X-Gm-Message-State: AODbwcA5A7ytz3b2bOUzy9l3jlMvp18SsxFPeas1ygaT9zzaRAVLpm0R furnwKFU+LzeLg== X-Received: by 10.28.167.197 with SMTP id q188mr21988963wme.79.1495368701818; Sun, 21 May 2017 05:11:41 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-1c23-04ca-53b1-12e4.holly.idiocy.org. [2001:8b0:3f8:8129:1c23:4ca:53b1:12e4]) by smtp.gmail.com with ESMTPSA id m38sm10262772wrm.4.2017.05.21.05.11.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2017 05:11:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215044 Archived-At: On Sun, May 21, 2017 at 12:46:53AM -0700, Paul Eggert wrote: > Alan Third wrote: > > I’ve stopped the signal handler from responding to SIGIO, > > I'm not following, as sigaction (SIGIO, ...) is still being called, so the > signal handler deliver_input_available_signal is still responding to SIGIO, > and is setting pending_signals to true. > > The changes you made affect SIGUSR1 and SIGUSR2 handling, since they patch > handle_user_signal: they cause the SIGUSR1 and SIGUSR2 handler to not > process SIGIO events. Also, they prevent SIGIO from being masked out during > non-SIGIO signal handlers. Is that what you intended? I'm not getting the > connection between these non-SIGIO handlers and interrupt_input. I’ve probably misunderstood what the code was doing. Would it be best to just leave the signal handlers as‐is, but replace the calls to raise(SIGIO) with direct calls as below? > > and the two > > places where the NS GUI used to raise SIGIO have been replaced with > > direct calls to the SIGIO handler code. > > That sounds like a reasonable thing to do in any event. I don't see why the > code needs to do a raise (SIGIO) when it can do a > handle_input_available_signal (SIGIO); Thanks! -- Alan Third