From: Alan Third <alan@idiocy.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: SIGIO and the NS port
Date: Sun, 21 May 2017 13:11:40 +0100 [thread overview]
Message-ID: <20170521121140.GA28789@breton.holly.idiocy.org> (raw)
In-Reply-To: <d949486f-8b8a-78d1-81b3-5632b051af30@cs.ucla.edu>
On Sun, May 21, 2017 at 12:46:53AM -0700, Paul Eggert wrote:
> Alan Third wrote:
> > I’ve stopped the signal handler from responding to SIGIO,
>
> I'm not following, as sigaction (SIGIO, ...) is still being called, so the
> signal handler deliver_input_available_signal is still responding to SIGIO,
> and is setting pending_signals to true.
>
> The changes you made affect SIGUSR1 and SIGUSR2 handling, since they patch
> handle_user_signal: they cause the SIGUSR1 and SIGUSR2 handler to not
> process SIGIO events. Also, they prevent SIGIO from being masked out during
> non-SIGIO signal handlers. Is that what you intended? I'm not getting the
> connection between these non-SIGIO handlers and interrupt_input.
I’ve probably misunderstood what the code was doing. Would it be best
to just leave the signal handlers as‐is, but replace the calls to
raise(SIGIO) with direct calls as below?
> > and the two
> > places where the NS GUI used to raise SIGIO have been replaced with
> > direct calls to the SIGIO handler code.
>
> That sounds like a reasonable thing to do in any event. I don't see why the
> code needs to do a raise (SIGIO) when it can do a
> handle_input_available_signal (SIGIO);
Thanks!
--
Alan Third
prev parent reply other threads:[~2017-05-21 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 12:41 SIGIO and the NS port Alan Third
2017-03-10 13:35 ` Eli Zaretskii
2017-03-13 16:38 ` Alan Third
2017-05-20 23:24 ` Alan Third
2017-05-21 7:46 ` Paul Eggert
2017-05-21 12:11 ` Alan Third [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521121140.GA28789@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.