From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: [PATCH 13/13] Avoid uninitialized read Date: Sat, 20 May 2017 16:58:41 +0200 Message-ID: <20170520145841.94282-13-phst@google.com> References: <20170520145841.94282-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495292459 10282 195.159.176.226 (20 May 2017 15:00:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 May 2017 15:00:59 +0000 (UTC) Cc: Philipp Stephani To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 20 17:00:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC5sB-0002TV-V2 for ged-emacs-devel@m.gmane.org; Sat, 20 May 2017 17:00:52 +0200 Original-Received: from localhost ([::1]:34506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dC5sH-00084S-J1 for ged-emacs-devel@m.gmane.org; Sat, 20 May 2017 11:00:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dC5qq-000805-UU for emacs-devel@gnu.org; Sat, 20 May 2017 10:59:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dC5qo-0003Jg-Cg for emacs-devel@gnu.org; Sat, 20 May 2017 10:59:28 -0400 Original-Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:36692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dC5qo-0003JS-5w for emacs-devel@gnu.org; Sat, 20 May 2017 10:59:26 -0400 Original-Received: by mail-wm0-x244.google.com with SMTP id k15so22060607wmh.3 for ; Sat, 20 May 2017 07:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CNwReMR5vnsWRmsTqKqBVdYPd7VuU7qY4uShEG/Ncfk=; b=nTF2SoYYqgMTiJ3wsalQUw3dF4BP6SJZp652Wrhq5jukLnp2SUWd1FvPGEW48iLsSJ peXhkt50f5uq7ACuH5VEPbs55ixWIKpOAg8douwmREJ5ucFD7Kc0iWR5SgQkUAdvBiKJ sNJgu6uvVU5tuyKX9GSCXbCwpbcKisv5lFiLDxgey0C6YUO72k0XgTpxxUWUdFQNKU2b mZUB203408El8obrZp0DKh1bwNIJlbHTGlJ70kkkJnlZh60+AjtBqmRoC7ubrrbzQGDy zaEVOcYG8hnXG7cVaOL6QZUv2xS9s1rB0Kmab6yq2JkeRo215hOATgSpXlRoN3zBphYx HKAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CNwReMR5vnsWRmsTqKqBVdYPd7VuU7qY4uShEG/Ncfk=; b=GOs9LZsOGuFNHwduMoxTQOZynKmiDyDLBPJp1HNJ2MjldAdmPwHOlwofzly6EZtGNs YHEMLiIKtRETF2NkpZihuwIYlJW+fgXCXLt6R4V3hA0uszXCpEaoSSm64m8OLBtIe1WJ H4A5L9q5wCzFvlxEsBGb7U1IQOJZkjC1i+NhgtaXJIzeXeJ/b6/pbqevKRmuLxxlNKyp X6WayPRexAqopX3swMRh+4wMtc1G3y6tnaVVyeo6vsIlmcmTc6rnGuwH1qnKIFyW6Og0 LZ3DGyTW8+zdVwddTXwYHVb9MrOYm+CT4SrExGjK91ubW04XNIdTaiO6hN8CS1XgcLl5 KGgQ== X-Gm-Message-State: AODbwcCKFCOeZZJy92+YPnVEtA8bsxXD5hYoMVkuSNG9mXtRQSl8Pm+e lcKfY5u+T3Wt20fLMzo= X-Received: by 10.28.203.143 with SMTP id b137mr8717872wmg.115.1495292364904; Sat, 20 May 2017 07:59:24 -0700 (PDT) Original-Received: from p.cm.cablesurf.de (46.128.198.151.dynamic.cablesurf.de. [46.128.198.151]) by smtp.gmail.com with ESMTPSA id 4sm7795937wrv.33.2017.05.20.07.59.23 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 20 May 2017 07:59:24 -0700 (PDT) X-Google-Original-From: Philipp Stephani X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170520145841.94282-1-phst@google.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215018 Archived-At: * src/nsterm.m (ns_read_socket): Don't read uninitialized variable 'nevents'. --- src/nsterm.m | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/nsterm.m b/src/nsterm.m index 27c5792800..33d053363f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -4261,6 +4261,8 @@ in certain situations (rapid incoming events). q_event_ptr = NULL; unblock_input (); } + else + return -1; return nevents; } -- 2.13.0