From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#26816: mouse movement support for OS X Date: Sun, 14 May 2017 14:59:10 +0100 Message-ID: <20170514135910.GA13710@breton.holly.idiocy.org> References: <20170507200034.GA661@breton.holly.idiocy.org> <20170509224435.GB8974@breton.holly.idiocy.org> <20170511214342.GA10431@breton.holly.idiocy.org> <3dc0d587-8290-f873-ceef-d059bec0b7f6@aurox.ch> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1494770426 10685 195.159.176.226 (14 May 2017 14:00:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 May 2017 14:00:26 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 26816@debbugs.gnu.org To: "Charles A. Roelli" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 14 16:00:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9u4E-0002Tv-S4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 May 2017 16:00:15 +0200 Original-Received: from localhost ([::1]:32854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9u4I-0006zt-EZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 May 2017 10:00:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9u46-0006yc-NH for bug-gnu-emacs@gnu.org; Sun, 14 May 2017 10:00:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9u43-0000NI-Kg for bug-gnu-emacs@gnu.org; Sun, 14 May 2017 10:00:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9u43-0000Mj-Gd for bug-gnu-emacs@gnu.org; Sun, 14 May 2017 10:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9u43-00085G-96 for bug-gnu-emacs@gnu.org; Sun, 14 May 2017 10:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 May 2017 14:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26816-submit@debbugs.gnu.org id=B26816.149477036130986 (code B ref 26816); Sun, 14 May 2017 14:00:03 +0000 Original-Received: (at 26816) by debbugs.gnu.org; 14 May 2017 13:59:21 +0000 Original-Received: from localhost ([127.0.0.1]:44849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9u3N-00083i-Jp for submit@debbugs.gnu.org; Sun, 14 May 2017 09:59:21 -0400 Original-Received: from mail-wr0-f177.google.com ([209.85.128.177]:35141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9u3M-00083V-0J for 26816@debbugs.gnu.org; Sun, 14 May 2017 09:59:20 -0400 Original-Received: by mail-wr0-f177.google.com with SMTP id z52so65283872wrc.2 for <26816@debbugs.gnu.org>; Sun, 14 May 2017 06:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LMVadZPvatpFpggmgr2WgkcccLxkd+xMR/w/JSaicV8=; b=R2kaCz5Hp3t2n6TvV0kK9ajwgAAwVQnL6mZBjV1MbfHw3zOLMLvP+EoSjbpmidQ1M3 MGat7OHgsqOdyfecM5XzVXRdH2Px6YfmCvxRK5rDd+IHeZfMCOTR9cuC429ftY9xyjwB Bh8eXl9PePVF5u7102rnb4aS4s0y14ProXPPGxn6s30zBGyXafgmFpXV+4+DmHNhFtDV u9Ff345M2kpD9m26MjytB7YNcQmTbuSAxqzfAO3/hjMzNae/GTYCj5WUxFSmhnnPrSkI q6MbHbB6RQSvfsQI80QeaqLwRIjX3KU5W3S2rhnmNEhe2lwSOs0ZDyaABVkS8N8hsFQw +0eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=LMVadZPvatpFpggmgr2WgkcccLxkd+xMR/w/JSaicV8=; b=rzTDy1DRD3GBZzQmo7PyXYiIXVO0EwGX6o0YaFH/qnMRlJr/JCF0mjIXAuNFOxpnYQ TXCXEHPXRxowxbjoElSgX/jRIQozWWZKmgnf00Yb38T3G1Udj29W6FwMvyTyU1QoASlh nzOVnUjmmgTjQZyeWj5/1leAbe072QkfCU1czaNBHKeKFdjvEkNRnCPSurONh8tC7AZ2 jdTLmzEhpOEy3cG8xxYEAMKwfwBh1f/2Fspdkfor/xhbu4yT1F/wGkkQB4PCwNXamUCl VbCrC7zFK9uNhPMoUic3rxE5eNfzuVLSUntzvUQMSfKJr+jFw2EDsnjTjrZkQuFXl9+o 7DTQ== X-Gm-Message-State: AODbwcDOtiO+Iletd1d5uQJTEkvqei3CzBKdIJS7IPNFOFpD3TVD8nwi NTUXUEePygGv3g== X-Received: by 10.223.168.97 with SMTP id l88mr1215685wrc.54.1494770354046; Sun, 14 May 2017 06:59:14 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-e9b1-3358-0f3c-df92.holly.idiocy.org. [2001:8b0:3f8:8129:e9b1:3358:f3c:df92]) by smtp.gmail.com with ESMTPSA id e187sm16712928wmf.31.2017.05.14.06.59.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 May 2017 06:59:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <3dc0d587-8290-f873-ceef-d059bec0b7f6@aurox.ch> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132497 Archived-At: On Sun, May 14, 2017 at 03:29:57PM +0200, Charles A. Roelli wrote: > Attached is a patch now working with multiple monitors. I also added > `ns-set-mouse-absolute-pixel-position', a test and a NEWS entry. The test > works interactively, but it requires a frame to run and I'm not sure whether > tests run with them by default. Usually you run tests with ’make check’, and there’s no frame available. I’ve just checked and it does throw up an error for that test. I’m not sure how that should be handled. > The code for handling the y-coord in `ns-set-mouse-absolute-pixel-position' > is from `ns-display-monitor-attributes-list' (in the calculation of the > screen geometry). I also made (set-mouse-absolute-pixel-position 0 0) put > the mouse in the top-left corner of the current screen. > > I tried out both `set-mouse-position' and > `set-mouse-absolute-pixel-position' on setups with the secondary monitor on > the left, right, top and bottom, and they seem to work right. > > I also got rid of the call to `ns_raise_frame' in > `frame_set_mouse_pixel_position', which is unnecessary. It all looks good to me. Leave this here a few days and if nobody complains push it to master. I’m not sure what to do about the test. If nobody offers a suggestion here, you could ask in emacs-devel. Thanks for working on this. -- Alan Third