From: Alan Third <alan@idiocy.org>
To: "Charles A. Roelli" <charles@aurox.ch>
Cc: 26816@debbugs.gnu.org
Subject: bug#26816: mouse movement support for OS X
Date: Sun, 14 May 2017 14:59:10 +0100 [thread overview]
Message-ID: <20170514135910.GA13710@breton.holly.idiocy.org> (raw)
In-Reply-To: <3dc0d587-8290-f873-ceef-d059bec0b7f6@aurox.ch>
On Sun, May 14, 2017 at 03:29:57PM +0200, Charles A. Roelli wrote:
> Attached is a patch now working with multiple monitors. I also added
> `ns-set-mouse-absolute-pixel-position', a test and a NEWS entry. The test
> works interactively, but it requires a frame to run and I'm not sure whether
> tests run with them by default.
Usually you run tests with ’make check’, and there’s no frame
available. I’ve just checked and it does throw up an error for that
test. I’m not sure how that should be handled.
> The code for handling the y-coord in `ns-set-mouse-absolute-pixel-position'
> is from `ns-display-monitor-attributes-list' (in the calculation of the
> screen geometry). I also made (set-mouse-absolute-pixel-position 0 0) put
> the mouse in the top-left corner of the current screen.
>
> I tried out both `set-mouse-position' and
> `set-mouse-absolute-pixel-position' on setups with the secondary monitor on
> the left, right, top and bottom, and they seem to work right.
>
> I also got rid of the call to `ns_raise_frame' in
> `frame_set_mouse_pixel_position', which is unnecessary.
It all looks good to me. Leave this here a few days and if nobody
complains push it to master. I’m not sure what to do about the test.
If nobody offers a suggestion here, you could ask in emacs-devel.
Thanks for working on this.
--
Alan Third
next prev parent reply other threads:[~2017-05-14 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 15:11 bug#26816: mouse movement support for OS X Charles A. Roelli
2017-05-07 16:51 ` Eli Zaretskii
2017-05-08 18:34 ` Charles A. Roelli
2017-05-08 18:54 ` Eli Zaretskii
2017-05-07 18:07 ` martin rudalics
2017-05-07 20:00 ` Alan Third
2017-05-09 19:09 ` Charles A. Roelli
2017-05-09 22:44 ` Alan Third
2017-05-11 18:06 ` Charles A. Roelli
2017-05-11 21:43 ` Alan Third
2017-05-14 13:29 ` Charles A. Roelli
2017-05-14 13:59 ` Alan Third [this message]
2017-05-14 14:37 ` Eli Zaretskii
2017-05-15 18:23 ` Charles A. Roelli
2017-05-16 22:53 ` Alan Third
2017-05-17 8:36 ` Andreas Schwab
2017-05-18 19:43 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514135910.GA13710@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=26816@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.