From: Alan Mackenzie <acm@muc.de>
To: Vasilij Schneidermann <mail@vasilij.de>
Cc: 26658@debbugs.gnu.org
Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map
Date: Sun, 7 May 2017 11:22:29 +0000 [thread overview]
Message-ID: <20170507112229.GA22721@acm.fritz.box> (raw)
In-Reply-To: <20170502211714.GB717@odonien.localdomain>
Hello, Vasilij.
On Tue, May 02, 2017 at 23:17:14 +0200, Vasilij Schneidermann wrote:
> I've ensured the bug is present and wrote a patch that fixes the issue.
> A workaround for people not using the latest cc-mode is to put the
> following into their init file:
> (eval-after-load 'cc-mode
> '(set-keymap-parent c-mode-base-map prog-mode-map))
Thanks for the patch.
[ .... ]
> (setq c-mode-base-map (make-sparse-keymap))
> + (c-set-keymap-parent c-mode-base-map prog-mode-map)
It doesn't seem to be quite right in the way it handles XEmacs stuff,
but I don't think it's possible to be "right" here, at least not
sensibly. If this patch were to be applied to standalone CC Mode, it
would test (derived-mode-p 'prog-mode) before calling
(c-set-keymap-parent c-mode-base-map prog-mode-map). prog-mode does not
exist in XEmacs, and is unlikely ever to exist there.
But this code is purely for Emacs. What do you think?
For the commit message, the format is to aim for a complete first line
which makes sense on its own. (It's a sentence, but without a
terminating full stop.) So something like this would do:
#########################################################################
Make prog-mode-map the keymap parent of c-mode-base-map
Fixes bug #26658.
* lisp/progmodes/cc-mode.el (c-set-keymap-parent): New function
extracted from c-make-inherited-keymap.
(c-mode-base-map): .......
#########################################################################
Note that the path is given before "cc-mode.el".
Do you have commit access to the Emacs repository?
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-05-07 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 18:52 bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Vasilij Schneidermann
2017-04-25 18:57 ` Glenn Morris
2017-04-26 6:30 ` bug#26658: " Jostein Kjønigsen
2017-04-26 6:37 ` Vasilij Schneidermann
2017-04-27 19:36 ` bug#26658: 25.2; " Alan Mackenzie
2017-04-28 8:15 ` Vasilij Schneidermann
2017-05-02 21:17 ` Vasilij Schneidermann
2017-05-07 11:22 ` Alan Mackenzie [this message]
2017-05-07 13:58 ` Vasilij Schneidermann
2017-07-12 17:50 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170507112229.GA22721@acm.fritz.box \
--to=acm@muc.de \
--cc=26658@debbugs.gnu.org \
--cc=mail@vasilij.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.