From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Date: Fri, 28 Apr 2017 10:15:22 +0200 Message-ID: <20170428081522.GA649@odonien.localdomain> References: <2136449839.36363.1493146365820@office.mailbox.org> <20170427193636.GA2683@acm> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1493393484 3359 195.159.176.226 (28 Apr 2017 15:31:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Apr 2017 15:31:24 +0000 (UTC) Cc: 26658@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 28 17:31:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d47ra-0000ih-HM for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Apr 2017 17:31:18 +0200 Original-Received: from localhost ([::1]:37599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d47rg-0000uT-9m for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Apr 2017 11:31:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d47rP-0000od-SQ for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2017 11:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d47rP-00086d-6e for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2017 11:31:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d47rL-00084O-5p; Fri, 28 Apr 2017 11:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d47rK-0000KD-W5; Fri, 28 Apr 2017 11:31:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 28 Apr 2017 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26658 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: wontfix Original-Received: via spool by 26658-submit@debbugs.gnu.org id=B26658.14933934541220 (code B ref 26658); Fri, 28 Apr 2017 15:31:02 +0000 Original-Received: (at 26658) by debbugs.gnu.org; 28 Apr 2017 15:30:54 +0000 Original-Received: from localhost ([127.0.0.1]:44862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d47rB-0000Jc-Cr for submit@debbugs.gnu.org; Fri, 28 Apr 2017 11:30:54 -0400 Original-Received: from mx1.mailbox.org ([80.241.60.212]:35243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d413y-0004Je-3w for 26658@debbugs.gnu.org; Fri, 28 Apr 2017 04:15:38 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 190C042543; Fri, 28 Apr 2017 10:15:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id rNVMUXyHih7I; Fri, 28 Apr 2017 10:15:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170427193636.GA2683@acm> X-Mailman-Approved-At: Fri, 28 Apr 2017 11:30:52 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132078 Archived-At: > So yes, this change would surely be a good idea, given that this CC Mode > is derived from prog-mode anyway. The more I think about it, the less sure I become. Pretty much every CC-derived mode does (define-derived-mode my-mode prog-mode ...) anyway and according to the macro expansion, its keymap's parent is set to (current-local-map) which should be equivalent to `prog-mode-map'. Could very well be a non-issue in practice and merely faulty testing by the user... > Do you want to write the patch? If so, have you got copyright > assignments, or can you manage to write it as an "insignificant" (i.e. > very small) change? I think the limit for insignificant changes is less > than 15 lines, but I'm not absolutely sure. This wouldn't even need any > changes in the manual. :-) > > If you don't really want to write the patch, just say so, and I'll do > it. I've assigned copyright already, but reckon this is a one-line patch. Before I submit anything, I'd like to make sure it's needed and the change works out as expected.