From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Date: Thu, 27 Apr 2017 19:36:36 +0000 Message-ID: <20170427193636.GA2683@acm> References: <2136449839.36363.1493146365820@office.mailbox.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1493321891 31447 195.159.176.226 (27 Apr 2017 19:38:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Apr 2017 19:38:11 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 26658@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 27 21:38:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3pEs-00086f-M9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Apr 2017 21:38:06 +0200 Original-Received: from localhost ([::1]:33936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3pEy-0000cB-Kv for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Apr 2017 15:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3pEs-0000bu-Ph for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2017 15:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3pEr-00044f-Tn for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2017 15:38:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3pEo-00043e-4D; Thu, 27 Apr 2017 15:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d3pEn-00030a-Vs; Thu, 27 Apr 2017 15:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Thu, 27 Apr 2017 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26658 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: wontfix Original-Received: via spool by 26658-submit@debbugs.gnu.org id=B26658.149332185311500 (code B ref 26658); Thu, 27 Apr 2017 19:38:01 +0000 Original-Received: (at 26658) by debbugs.gnu.org; 27 Apr 2017 19:37:33 +0000 Original-Received: from localhost ([127.0.0.1]:43239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3pEL-0002zQ-FX for submit@debbugs.gnu.org; Thu, 27 Apr 2017 15:37:33 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:40728 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3pEJ-0002zC-TE for 26658@debbugs.gnu.org; Thu, 27 Apr 2017 15:37:32 -0400 Original-Received: (qmail 22558 invoked by uid 3782); 27 Apr 2017 19:37:29 -0000 Original-Received: from acm.muc.de (p548C7144.dip0.t-ipconnect.de [84.140.113.68]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 27 Apr 2017 21:37:28 +0200 Original-Received: (qmail 4549 invoked by uid 1000); 27 Apr 2017 19:36:36 -0000 Content-Disposition: inline In-Reply-To: <2136449839.36363.1493146365820@office.mailbox.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132060 Archived-At: Hello, Vasilij. On Tue, Apr 25, 2017 at 20:52:45 +0200, Vasilij Schneidermann wrote: > See title. Modes derived from cc-mode inherit its keybindings, however > they won't inherit keys defined in prog-mode-map. This could probably > be rectified by using (set-keymap-parent c-mode-base-map prog-mode-map) > at the strategically correct location (like the lengthy top-level if > form setting up that map). Is there any reason to *not* have this > change? I'd otherwise write a patch for it. I've been trying to think of good reasons not to do this (on the CC Mode within Emacs), and haven't been able to come up with any yet. ;-) I think it's more likely that as define-derived-mode and prog-mode gradually congealed into existence, prog-mode-map got left out of c-mode-base-map, sort of forgotten. So yes, this change would surely be a good idea, given that this CC Mode is derived from prog-mode anyway. Do you want to write the patch? If so, have you got copyright assignments, or can you manage to write it as an "insignificant" (i.e. very small) change? I think the limit for insignificant changes is less than 15 lines, but I'm not absolutely sure. This wouldn't even need any changes in the manual. :-) If you don't really want to write the patch, just say so, and I'll do it. Thanks for the bug report! -- Alan Mackenzie (Nuremberg, Germany).