From: Alan Mackenzie <acm@muc.de>
To: Vasilij Schneidermann <mail@vasilij.de>
Cc: 26658@debbugs.gnu.org
Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map
Date: Thu, 27 Apr 2017 19:36:36 +0000 [thread overview]
Message-ID: <20170427193636.GA2683@acm> (raw)
In-Reply-To: <2136449839.36363.1493146365820@office.mailbox.org>
Hello, Vasilij.
On Tue, Apr 25, 2017 at 20:52:45 +0200, Vasilij Schneidermann wrote:
> See title. Modes derived from cc-mode inherit its keybindings, however
> they won't inherit keys defined in prog-mode-map. This could probably
> be rectified by using (set-keymap-parent c-mode-base-map prog-mode-map)
> at the strategically correct location (like the lengthy top-level if
> form setting up that map). Is there any reason to *not* have this
> change? I'd otherwise write a patch for it.
I've been trying to think of good reasons not to do this (on the CC Mode
within Emacs), and haven't been able to come up with any yet. ;-)
I think it's more likely that as define-derived-mode and prog-mode
gradually congealed into existence, prog-mode-map got left out of
c-mode-base-map, sort of forgotten.
So yes, this change would surely be a good idea, given that this CC Mode
is derived from prog-mode anyway.
Do you want to write the patch? If so, have you got copyright
assignments, or can you manage to write it as an "insignificant" (i.e.
very small) change? I think the limit for insignificant changes is less
than 15 lines, but I'm not absolutely sure. This wouldn't even need any
changes in the manual. :-)
If you don't really want to write the patch, just say so, and I'll do
it.
Thanks for the bug report!
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-04-27 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 18:52 bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Vasilij Schneidermann
2017-04-25 18:57 ` Glenn Morris
2017-04-26 6:30 ` bug#26658: " Jostein Kjønigsen
2017-04-26 6:37 ` Vasilij Schneidermann
2017-04-27 19:36 ` Alan Mackenzie [this message]
2017-04-28 8:15 ` bug#26658: 25.2; " Vasilij Schneidermann
2017-05-02 21:17 ` Vasilij Schneidermann
2017-05-07 11:22 ` Alan Mackenzie
2017-05-07 13:58 ` Vasilij Schneidermann
2017-07-12 17:50 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427193636.GA2683@acm \
--to=acm@muc.de \
--cc=26658@debbugs.gnu.org \
--cc=mail@vasilij.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.