From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#22060: 25.1.50; Fringe faces or not honored in 25.1.50.1 on OSX 10.11 installed via homebrew --use-git-head --cocoa Date: Mon, 24 Apr 2017 10:48:08 +0100 Message-ID: <20170424094808.GA99570@breton.holly.idiocy.org> References: <30EE68E8-0158-4079-8DD4-B80599305039@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1493027355 5765 195.159.176.226 (24 Apr 2017 09:49:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2017 09:49:15 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 22060@debbugs.gnu.org To: Henrik Nyman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 24 11:49:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2acI-0001Kl-5r for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Apr 2017 11:49:10 +0200 Original-Received: from localhost ([::1]:42995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2acM-0003Dq-EL for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Apr 2017 05:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2acG-0003Dh-Q3 for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:49:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2acD-0007R0-MD for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:49:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2acD-0007QI-Hi for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:49:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d2ac9-0004qL-J2 for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 05:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2017 09:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22060-submit@debbugs.gnu.org id=B22060.149302729918562 (code B ref 22060); Mon, 24 Apr 2017 09:49:01 +0000 Original-Received: (at 22060) by debbugs.gnu.org; 24 Apr 2017 09:48:19 +0000 Original-Received: from localhost ([127.0.0.1]:37105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2abS-0004pK-TJ for submit@debbugs.gnu.org; Mon, 24 Apr 2017 05:48:19 -0400 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:33566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2abR-0004p7-OE for 22060@debbugs.gnu.org; Mon, 24 Apr 2017 05:48:18 -0400 Original-Received: by mail-wm0-f47.google.com with SMTP id i137so4155048wmf.0 for <22060@debbugs.gnu.org>; Mon, 24 Apr 2017 02:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XYdIVbiEJwKcLCRgKso84/LMXGi5aXnDHXNK5YMKaSc=; b=JKwSSBHGlvnpW3f6UiHTZjPT1TbU31+MoAJNwIg08coL8Xgub2IcbQUz751+midqU0 MY29sqzUDbYjovH8ISEC/JdOisGIp9abWvrWMtVOXRcEbYOw6GRXlAZ9V0Zeglc3XIEU ubdPLrDbC7eY+QZpo4C15BM9smxSv6iIPFDAfXznRtKtjriRyPm75Va9j5OZIaoS/xnK urkeB17zeNKlcDNJYqnBgThG+o74XIx8nfb9H96uSxvYBtHbn5bDSr/SQ5OlmCq6a/kM hSLYp46sWoqd5UabwTALfjkBPVh554O6EEbIdtR8oaCMOP6SixD+xNM4OW8Q4N0l7nUM Omlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=XYdIVbiEJwKcLCRgKso84/LMXGi5aXnDHXNK5YMKaSc=; b=KYkihs3As54roYEQhlSKCAFj+oZVdOnAej9O349ggwLgNhOmJX6WX0pjgvYAnnR41Y a9kPbDrNsEM06ETeP8zHq1PVUu/6OL/Bot+hUfU/Rpp7vCfGVuoOe79IK4adJ5cBplb7 M+S5jTFFPy91wFnOkzjDbdl4SRp1buZj2rWexiInewSi7jjxobIaiaTCK8RVs1KnR5uF evqUTnzPMgo78blHeYdBdftPr0pgDoKZ4o3qEBmBFavhSosOvC0vs2PX800Qy9fCB2aG 5Xs/QSksOXjEsu/DcX/dNB6FeODQoTd9QN8RDLgtinbZXN2QQAwn2qjb1oZHo0OWPC9G sv5A== X-Gm-Message-State: AN3rC/6I/87kC8GxJ/vh+dMD2GtdQF5NdvFfgC0i6iQrKt0rFisNnkFb AEOO9DlM8XNusA== X-Received: by 10.28.129.65 with SMTP id c62mr8706262wmd.79.1493027292025; Mon, 24 Apr 2017 02:48:12 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-2cd9-a808-0379-2280.holly.idiocy.org. [2001:8b0:3f8:8129:2cd9:a808:379:2280]) by smtp.gmail.com with ESMTPSA id z90sm3745163wrc.36.2017.04.24.02.48.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Apr 2017 02:48:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131928 Archived-At: On Sun, Apr 23, 2017 at 07:40:17PM +0000, Henrik Nyman wrote: > Referred to this issue at: > > https://github.com/flycheck/flycheck/issues/811#issuecomment-296476404 > > > I hope this helps with creating a proper fix. I’ve pushed a fix to the master branch. Can you please give it a try? > (there probably was a reason to save the foreground color in a > member variable in the first place). I think the old code just looked at the alpha channel to determine whether any particular pixel was background or foreground, but the new code uses the actual colour value. If you then change the foreground colour, you have to look for that new colour the next time you want to change it. I’m not really sure why that specific change was made. I can only assume that the alpha channel isn’t always a perfect guide. -- Alan Third