From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: master cd0a795: Output number of characters added to file (Bug#354) Date: Fri, 7 Apr 2017 20:16:00 -0400 Message-ID: <20170408001600.m3oq4ynv3cayrjqx@holos.localdomain> References: <20170407022529.14820.30445@vcs0.savannah.gnu.org> <20170407022531.17D812084C@vcs0.savannah.gnu.org> <87r3143ndq.fsf@holos> <837f2wofjy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1491610611 24988 195.159.176.226 (8 Apr 2017 00:16:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Apr 2017 00:16:51 +0000 (UTC) User-Agent: NeoMutt/20170306 (1.8.0) Cc: kb1vqh@gmail.com, npostavs@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 08 02:16:45 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwe3Q-0004ss-TE for ged-emacs-devel@m.gmane.org; Sat, 08 Apr 2017 02:16:37 +0200 Original-Received: from localhost ([::1]:53038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwe3V-00051b-Cc for ged-emacs-devel@m.gmane.org; Fri, 07 Apr 2017 20:16:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwe2w-00051T-Ns for emacs-devel@gnu.org; Fri, 07 Apr 2017 20:16:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwe2s-0008ET-A5 for emacs-devel@gnu.org; Fri, 07 Apr 2017 20:16:06 -0400 Original-Received: from mail-qt0-x22f.google.com ([2607:f8b0:400d:c0d::22f]:34871) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwe2s-0008DN-4n for emacs-devel@gnu.org; Fri, 07 Apr 2017 20:16:02 -0400 Original-Received: by mail-qt0-x22f.google.com with SMTP id x35so72863511qtc.2 for ; Fri, 07 Apr 2017 17:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4MjJG98jvK3rCq0ya96ym710pFU3g85Ljs+4Fgitqog=; b=iwlfaZ1qAic5POvNfH+aObF/wG/wqShgpadburYWKO+l4tHKSlV6O4fskYbQ/10YI1 q3QOXTVFkudCtFW6JfY0kythg4bsaxHgpRzfLAVxId6yF0WviSEwqHzxa12l9xtnyVtC bg4M95dnYJsgOYcgjTGIql8ySatf8kPCkDJXXH8gkBexmq+yAJGhG6R+oGHrFgOP2Hjf 8agGMcRBk9+6c3GDQToPXEgXEgFucZM7AFSzzwh4i3kjw8d23sqYI2KTqeiFWkmhN+ZZ FNULYF4aHX3WB2iIKy5Z8AuY7DatTPjhS66sp1KHQId0HUACUmsTV9K9gD5ZtZXgxDQp gQ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4MjJG98jvK3rCq0ya96ym710pFU3g85Ljs+4Fgitqog=; b=ECdm2vXJv860jjDy8usL0yWevKxzQJPdbm4jXPtovHqj5Qg1WxIDWNElnPSF9ZRkoe 0aozqwxSlbJovB6XPHuhl1xpkvvH+cxITvHJpyVf7628tJ5uJHE2GxTaYHPa8TfXUdTa 9aajke/62Yx8ZISI1DE5JSENVRRHJXGfbrovl4rCI5M03TPlyWweZOK3gW1i+ILMFFgV zSDIwhKwCTsS1xZ4OnDxoYyeL0F6kJJP+t2nYpVgzv3ykxgzd+FWWeMU7TLft+emhE3O vfUU6hrf7PHYA7ycnBfWI86ppLIctRukEt1FGA+iIwMOaSkFQOh7yvro9mA9dVojl/05 28dQ== X-Gm-Message-State: AFeK/H3a6YtNOqXAkfgc54X7AOkdUH8Nhbd54e0pGmJk6QEKth9vdF2kjRumJCrBm/TITJjc X-Received: by 10.237.53.143 with SMTP id c15mr41413080qte.49.1491610561307; Fri, 07 Apr 2017 17:16:01 -0700 (PDT) Original-Received: from holos.localdomain (pool-96-234-164-232.bltmmd.fios.verizon.net. [96.234.164.232]) by smtp.gmail.com with ESMTPSA id d30sm4106262qtb.18.2017.04.07.17.16.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 17:16:00 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 0F7CC66126; Fri, 7 Apr 2017 20:16:00 -0400 (EDT) Content-Disposition: inline In-Reply-To: <837f2wofjy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213792 Archived-At: On 07/04/17 at 10:14am, Eli Zaretskii wrote: > > From: Mark Oteiza > > Date: Thu, 06 Apr 2017 23:30:41 -0400 > > Cc: Jeff Clough , Noam Postavsky > > > > > Output number of characters added to file (Bug#354) > > > > > > * fileio.c (write_region): > > > * epa-file.el (epa-file-write-region): > > > * jka-compr.el (jka-compr-write-region): > > > * ange-ftp.el (ange-ftp-write-region): > > > * tramp-gvfs.el (tramp-gvfs-handle-write-region): > > > * tramp-sh.el (tramp-sh-handle-write-region): > > > * mm-util.el (mm-append-to-file): Functions now output > > > characters written in addition to file name. > > > * files.texi: Added documentation to write-region and > > > append-to-file describing their output. > > > > This behavior is unnecessarily verbose, at least when just interactively > > saving buffers. Haven't tested this otherwise. If I cared about the > > number of characters in the buffer I'd look in the mode line or just do > > C-x =. > > > > I can't say I've ever been surprised as described in the original > > report. > > Thanks for the comments. Would making this an optional feature take > care of your concerns? Indeed it would, and IMO it should default to disabled. > P.S. In the future, it might be better to voice such objections while > the patch is being discussed, to avoid unnecessary reworking and > possible frustration caused by that. TIA. Of course; however, this only grabbed my attention seeing it after rebuilding.