Re: UI Unresponsive Again on macOS

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Fri, Mar 10, 2017 at 06:40:00AM -0800, Bob Halley wrote:
> I build from the master branch about once a week. I had no problem
> with last week's build made early in the morning California time on
> Sunday the 6th, but the build I just made this morning becomes
> completely unresponsive after a short time. I don't have an exact
> recipe to reproduce -- I was just typing, and then stopped for a
> bit, and then it became completely unresponsive. This happens every
> time I try to use it.
> 
> I suspect one or both of these changes:
> 
> a65236214d9202fb69a6ba5169d4ac1a4bcb0b0d
> 3bd2e9e975ed29daaf03ca7559e4664aade0674f
> 
> as they are new since my last working build and seem to be relevant.
> 
> I obtained backtraces of all the threads. I did two snapshots of
> thread 1 as it seemed to be spinning a bit.

Thanks for that, Bob. I noticed these hangs too, but I haven’t
actually managed to catch one in the debugger yet.

Can you please try the attached patch? I’m not at all sure it’ll fix
it, but it’ll be good to rule it out.
-- 
Alan Third

[-- Attachment #2: Disable SIGIO --]
[-- Type: text/plain, Size: 1375 bytes --]

From 6b4787023b247b68ae0598d03dce50a6fce44ab1 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Fri, 10 Mar 2017 14:21:14 +0000
Subject: [PATCH] Disable SIGIO processing on NS port

* src/conf_post.h: undef USABLE_SIGIO and INTERRUPT_INPUT.
* src/nsterm.m (hold_event, ns_select): Remove unneeded calls to raise
SIGIO.
---
 src/conf_post.h | 6 ++++++
 src/nsterm.m    | 3 ---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/conf_post.h b/src/conf_post.h
index e146b9bbe8..3b6b9aff8d 100644
--- a/src/conf_post.h
+++ b/src/conf_post.h
@@ -355,3 +355,9 @@ extern int emacs_setenv_TZ (char const *);
 #else
 # define UNINIT /* empty */
 #endif
+
+/* The NS port doesn't use SIGIO for input. */
+#ifdef HAVE_NS
+# undef USABLE_SIGIO
+# undef INTERRUPT_INPUT
+#endif
diff --git a/src/nsterm.m b/src/nsterm.m
index f985786e19..d61d357811 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -454,8 +454,6 @@ - (NSColor *)colorUsingDefaultColorSpace
     }
 
   hold_event_q.q[hold_event_q.nr++] = *event;
-  /* Make sure ns_read_socket is called, i.e. we have input.  */
-  raise (SIGIO);
   send_appdefined = YES;
 }
 
@@ -4120,7 +4118,6 @@ in certain situations (rapid incoming events).
   if (hold_event_q.nr > 0)
     {
       /* We already have events pending. */
-      raise (SIGIO);
       errno = EINTR;
       return -1;
     }
-- 
2.12.0