From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: SIGIO and the NS port Date: Fri, 10 Mar 2017 12:41:17 +0000 Message-ID: <20170310124117.GA74077@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1489149742 21285 195.159.176.226 (10 Mar 2017 12:42:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Mar 2017 12:42:22 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) To: Emacs-Devel devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 10 13:42:19 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmJs8-0004nn-CB for ged-emacs-devel@m.gmane.org; Fri, 10 Mar 2017 13:42:16 +0100 Original-Received: from localhost ([::1]:38743 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmJsE-0006aH-2X for ged-emacs-devel@m.gmane.org; Fri, 10 Mar 2017 07:42:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmJrO-0006Aj-2X for emacs-devel@gnu.org; Fri, 10 Mar 2017 07:41:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmJrN-0000Id-4F for emacs-devel@gnu.org; Fri, 10 Mar 2017 07:41:30 -0500 Original-Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:34595) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cmJrM-0000He-Sh for emacs-devel@gnu.org; Fri, 10 Mar 2017 07:41:29 -0500 Original-Received: by mail-wr0-x236.google.com with SMTP id l37so64178288wrc.1 for ; Fri, 10 Mar 2017 04:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=SL+3gteC6rOwmWkedzIRPcRk+UzlnWTLSS5fW2CLKBs=; b=Urw1g3UhffjqXn1TQ/q4Ad8A5ZkcVQMCuRYZRT39NtIbRfWpUwCXHDG6t9EV4/5c3x ycHVsY5NzR2Eb+evYw/SlX1luHIksbI++JKCKohwsJvT/SfSCnpgVUyVX6Mgqu61yd32 UT1nRXTrfpMxqQghxtJ84Lp7xoJLnUXVs4E8VK1T2NXfeRUZl7/WajY5XkSU2LyY/UkZ zabR9SUfomgDlpMCaz45UzUvCGLEvEiarBSw5ahUP+jTNpU7D3rXA+spQYTtvUsfAiT9 JsnUrwewFCDi8HoG3KB4pxHt95v7k/qW5ZiLmLFheZJQ6gy/NysxVuFJbCzTk434ThGH MONA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :mime-version:content-disposition:content-transfer-encoding :user-agent; bh=SL+3gteC6rOwmWkedzIRPcRk+UzlnWTLSS5fW2CLKBs=; b=cAbIBY27Q6wK3mJiK/XEsbYHJm4rFSPQnNcCUXwPLx3fG1Sa9tgWUlvxrFL7MR4awi tMT4d47DZHBkZSXSKgB9/K9hlmqhEcCytKqihERD8v3uAC3+NRLZ1CsNX+/t8Q1sWZQ3 XJcQjAsYfhSkyD1rHY6VihYscdYnbEgf5m5z5kHqras3v607olbjrI4bJ1ABK0dKeUFa hLLhXyRaPu6xX0Rn/bueM70yWlTvj8CX+j0KkXwLMBXWsJVLFwobuardLEoNpy2LJZBY VpKr6rpGfDZxvrQZvCcFkiUAyeTBARZ57kDiRZrRqnByObV7kmxrHZ3QAhc89twsQsBR PjkA== X-Gm-Message-State: AMke39n9Uzccpmf/J3CTaJUgLupyLTw2R8G8XYTkib2sPOZRoYXextPfnImnQcKuB8g96Q== X-Received: by 10.223.164.85 with SMTP id e21mr15881601wra.58.1489149685893; Fri, 10 Mar 2017 04:41:25 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a458-8f8c-9e16-1775.holly.idiocy.org. [2001:8b0:3f8:8129:a458:8f8c:9e16:1775]) by smtp.gmail.com with ESMTPSA id h3sm12706925wrb.6.2017.03.10.04.41.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 04:41:24 -0800 (PST) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212881 Archived-At: I think I’ve just found a simple solution to a whole class of bugs in the NS port. We’ve had a number of bug reports where Emacs crashes while doing UI related things, for example minimizing the frame, and generally we’ve found the best way to deal with these is by wrapping the relevant bit in block_input/unblock_input. Today I discovered that config.h on my machine has two defines related to SIGIO: #define INTERRUPT_INPUT 1 #define USABLE_SIGIO 1 The NS port doesn’t use SIGIO to signal for input (I think it polls using ns_select), and if I comment these two defines out I can remove block_input/unblock_input from various places with no ill effects. Does anyone know of any reason not to remove these two defines? How would I go about doing that? I assume config.h is generated by ./configure, but I don’t know anything about that side of things. Thanks! -- Alan Third