From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#25077: 25.1; Incorrect Edebug spec for c-lang-defvar Date: Sat, 18 Feb 2017 16:10:52 +0000 Message-ID: <20170218161052.GB2503@acm> References: <83h94a8aby.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1487434335 7613 195.159.176.226 (18 Feb 2017 16:12:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 16:12:15 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 25077-done@debbugs.gnu.org To: Gemini Lasswell , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 18 17:12:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf7cF-000176-PM for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Feb 2017 17:12:07 +0100 Original-Received: from localhost ([::1]:58986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf7cL-0001LI-GP for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Feb 2017 11:12:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf7cE-0001Ju-Uz for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 11:12:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf7cA-00037z-VF for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 11:12:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cf7cA-00037p-RS; Sat, 18 Feb 2017 11:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cf7cA-00006y-GA; Sat, 18 Feb 2017 11:12:02 -0500 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 18 Feb 2017 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25077 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Mail-Followup-To: 25077@debbugs.gnu.org, acm@muc.de, gazally@runbox.com Original-Received: via spool by 25077-done@debbugs.gnu.org id=D25077.1487434278364 (code D ref 25077); Sat, 18 Feb 2017 16:12:02 +0000 Original-Received: (at 25077-done) by debbugs.gnu.org; 18 Feb 2017 16:11:18 +0000 Original-Received: from localhost ([127.0.0.1]:45202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf7bS-00005o-9D for submit@debbugs.gnu.org; Sat, 18 Feb 2017 11:11:18 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:57476 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cf7bQ-00005g-Ke for 25077-done@debbugs.gnu.org; Sat, 18 Feb 2017 11:11:17 -0500 Original-Received: (qmail 80371 invoked by uid 3782); 18 Feb 2017 16:11:14 -0000 Original-Received: from acm.muc.de (p4FC46853.dip0.t-ipconnect.de [79.196.104.83]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 18 Feb 2017 17:11:13 +0100 Original-Received: (qmail 11101 invoked by uid 1000); 18 Feb 2017 16:10:52 -0000 Content-Disposition: inline In-Reply-To: <83h94a8aby.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129510 Archived-At: Hello, Gemini and Eli. On Sat, Feb 04, 2017 at 13:27:45 +0200, Eli Zaretskii wrote: > > From: Gemini Lasswell > > Date: Wed, 30 Nov 2016 11:20:28 -0800 > > The Edebug spec for c-lang-defvar doesn't allow for the use of > > 'dont-doc, which prevents the use of Edebug and Testcover on > > cc-langs.el. > > To reproduce, using emacs -Q starting at the root of the Emacs > > sources: > > M-: (require 'cc-langs) RET > > C-x C-f lisp/progmodes/cc-langs.el RET > > C-s dont-doc RET > > C-u C-M-x > > Result: edebug-syntax-error: Invalid read syntax: stringp, "failed" > > I tried this change to the Edebug spec for c-lang-defvar, and it makes > > Edebug work on all the c-lang-defvar uses in this file: > > (def-edebug-spec c-lang-defvar > > (&define name def-form &optional &or ("quote" "dont-doc") stringp)) Thanks, both for reporting this bug and for fixing it. :-) > > Alternatively, the 'dont-doc could be removed from the 7 places it is > > used. The majority of c-lang-defvar calls simply omit the docstring, > > and the code in c-lang-defvar is not doing any checking for dont-doc, > > it simply ignores that parameter if it is not a string. After some consideration, I amended the edebug-spec like you suggested, but also removed the two occurrences of 'dont-doc which had no effect. I've committed the change to master, and I'm closing this bug as fixed. > Alan, could you please look into this? > Thanks. -- Alan Mackenzie (Nuremberg, Germany).