From: Michal Nazarewicz <mina86@mina86.com>
To: 25677@debbugs.gnu.org
Subject: bug#25677: [PATCH 01/22] oldXMenu: add missing #include <string.h>
Date: Fri, 10 Feb 2017 19:16:37 +0100 [thread overview]
Message-ID: <20170210181637.15565-1-mina86@mina86.com> (raw)
Some of the files in oldXMenu use functions from string.h without
including that header which results in compile warnings:
ChgPane.c:46:5: warning: implicit declaration of function ‘strlen’
ChgPane.c:46:20: warning: incompatible implicit declaration of
built-in function ‘strlen’
ChgSel.c:62:2: warning: implicit declaration of function ‘strlen’
ChgSel.c:62:17: warning: incompatible implicit declaration of built-in
function ‘strlen’
Create.c:220:5: warning: implicit declaration of function ‘strcmp’
InsPane.c:65:5: warning: implicit declaration of function ‘strlen’
InsPane.c:65:20: warning: incompatible implicit declaration of
built-in function ‘strlen’
InsSel.c:68:5: warning: implicit declaration of function ‘strlen’
InsSel.c:68:20: warning: incompatible implicit declaration of built-in
function ‘strlen’
InsSel.c:75:5: warning: implicit declaration of function ‘strcmp’
Add the necessary ‘#include <string.h>’.
oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPane.c,
oldXMenu/InsSel.c: add missing #include <string.h>
---
| 1 +
| 1 +
| 1 +
| 1 +
| 1 +
5 files changed, 5 insertions(+)
Unless there are some objections I’ll commit this in a few days.
--git a/oldXMenu/ChgPane.c b/oldXMenu/ChgPane.c
index d2977b73faf..733f65950f5 100644
--- a/oldXMenu/ChgPane.c
+++ b/oldXMenu/ChgPane.c
@@ -14,6 +14,7 @@
*/
#include "XMenuInt.h"
+#include <string.h>
int
XMenuChangePane(register XMenu *menu, register int p_num, char *label)
--git a/oldXMenu/ChgSel.c b/oldXMenu/ChgSel.c
index d24e61f56d5..5a46b5cf587 100644
--- a/oldXMenu/ChgSel.c
+++ b/oldXMenu/ChgSel.c
@@ -14,6 +14,7 @@
*/
#include "XMenuInt.h"
+#include <string.h>
int
XMenuChangeSelection(Display *display, register XMenu *menu, register int p_num, register int s_num, char *data, int data_sw, char *label, int label_sw)
--git a/oldXMenu/Create.c b/oldXMenu/Create.c
index 0e72a2d2e58..a0913685365 100644
--- a/oldXMenu/Create.c
+++ b/oldXMenu/Create.c
@@ -31,6 +31,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "XMenuInt.h"
#include <stdlib.h>
+#include <string.h>
#ifdef EMACS_BITMAP_FILES
#include "../src/bitmaps/dimple1.xbm"
--git a/oldXMenu/InsPane.c b/oldXMenu/InsPane.c
index d8470f3a5bf..da92f49aa77 100644
--- a/oldXMenu/InsPane.c
+++ b/oldXMenu/InsPane.c
@@ -15,6 +15,7 @@
*/
#include "XMenuInt.h"
+#include <string.h>
int
XMenuInsertPane(register XMenu *menu, register int p_num, char *label, int active)
--git a/oldXMenu/InsSel.c b/oldXMenu/InsSel.c
index 66f4968197d..f5380437958 100644
--- a/oldXMenu/InsSel.c
+++ b/oldXMenu/InsSel.c
@@ -14,6 +14,7 @@
*/
#include "XMenuInt.h"
+#include <string.h>
int
XMenuInsertSelection(register XMenu *menu, register int p_num, register int s_num, char *data, char *label, int active)
--
2.11.0.483.g087da7b7c-goog
next reply other threads:[~2017-02-10 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 18:16 Michal Nazarewicz [this message]
2017-02-15 16:13 ` bug#25677: [PATCH 01/22] oldXMenu: add missing #include <string.h> Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210181637.15565-1-mina86@mina86.com \
--to=mina86@mina86.com \
--cc=25677@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.