From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Bug #25608 and the comment-cache branch Date: Fri, 3 Feb 2017 16:19:13 +0000 Message-ID: <20170203161913.GA2250@acm> References: <20170202202418.GA2505@acm> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1486138987 16341 195.159.176.226 (3 Feb 2017 16:23:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2017 16:23:07 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 03 17:23:04 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZgdS-0003mL-Ku for ged-emacs-devel@m.gmane.org; Fri, 03 Feb 2017 17:22:54 +0100 Original-Received: from localhost ([::1]:35604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZgdY-00041a-05 for ged-emacs-devel@m.gmane.org; Fri, 03 Feb 2017 11:23:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZgaH-0001QG-E1 for emacs-devel@gnu.org; Fri, 03 Feb 2017 11:19:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZgaE-0004OB-6V for emacs-devel@gnu.org; Fri, 03 Feb 2017 11:19:37 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:51955 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cZgaD-0004O1-SA for emacs-devel@gnu.org; Fri, 03 Feb 2017 11:19:34 -0500 Original-Received: (qmail 76774 invoked by uid 3782); 3 Feb 2017 16:19:32 -0000 Original-Received: from acm.muc.de (p548C746C.dip0.t-ipconnect.de [84.140.116.108]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 03 Feb 2017 17:19:31 +0100 Original-Received: (qmail 2273 invoked by uid 1000); 3 Feb 2017 16:19:13 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211938 Archived-At: Hello, Stefan. On Thu, Feb 02, 2017 at 18:57:52 -0500, Stefan Monnier wrote: > > ....), the last line spuriously indents c-basic-offset columns > > rightwards. The cause of this is the open paren at column zero inside > > the comment. > I think it's important to remember that this problem dates back to > Emacs-17 or so, so it's not super urgent to install a quick fix. There's no need to be so disparaging. comment-cache is NOT in any sense a "quick fix". It's precisely the opposite. It's a rigorous rewrite of back_comment which eliminates "quick fixes", for example open-paren-in-column-0-is-defun-start. I think you know this. And given how long this problem's been around for, it's high time it was finally fixed. It's an embarrassment, and it causes pain, repeatedly and predictably. Instead, why don't you criticise comment-cache in a constructive fashion? Such as by pointing out potential problems it might cause. > Stefan -- Alan Mackenzie (Nuremberg, Germany).