From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Date: Mon, 23 Jan 2017 20:12:32 +0000 Message-ID: <20170123201232.GB4397@acm> References: <87h967cj0f.fsf@users.sourceforge.net> <87eg1bcg0y.fsf@users.sourceforge.net> <20161214215834.GB3881@acm.fritz.box> <20161215164458.GA2437@acm.fritz.box> <8737hldce8.fsf@users.sourceforge.net> <20161229111428.GA12532@acm.fritz.box> <87eg0q89ky.fsf@users.sourceforge.net> <87mvevzp8q.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1485202399 6118 195.159.176.226 (23 Jan 2017 20:13:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 23 Jan 2017 20:13:19 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 24870@debbugs.gnu.org, Matt Armstrong To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 23 21:13:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVkzE-0000tV-Hu for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jan 2017 21:13:08 +0100 Original-Received: from localhost ([::1]:44250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVkzJ-0008Me-Mh for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jan 2017 15:13:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVkzD-0008L3-9k for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 15:13:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVkz8-0004ad-7B for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 15:13:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41235) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cVkz8-0004aZ-3r for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 15:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cVkz7-0007sY-Uo for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 15:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2017 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24870-submit@debbugs.gnu.org id=B24870.148520237330269 (code B ref 24870); Mon, 23 Jan 2017 20:13:01 +0000 Original-Received: (at 24870) by debbugs.gnu.org; 23 Jan 2017 20:12:53 +0000 Original-Received: from localhost ([127.0.0.1]:39434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVkyy-0007s9-LI for submit@debbugs.gnu.org; Mon, 23 Jan 2017 15:12:52 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:42375 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cVkyw-0007rz-JG for 24870@debbugs.gnu.org; Mon, 23 Jan 2017 15:12:51 -0500 Original-Received: (qmail 15936 invoked by uid 3782); 23 Jan 2017 20:12:48 -0000 Original-Received: from acm.muc.de (p548C72B0.dip0.t-ipconnect.de [84.140.114.176]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 23 Jan 2017 21:12:47 +0100 Original-Received: (qmail 4866 invoked by uid 1000); 23 Jan 2017 20:12:32 -0000 Content-Disposition: inline In-Reply-To: <87mvevzp8q.fsf@users.sourceforge.net> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128341 Archived-At: Hello, Noam. Sorry this is very late, but better that than not at all. On Thu, Jan 12, 2017 at 21:07:49 -0500, npostavs@users.sourceforge.net wrote: > npostavs@users.sourceforge.net writes: > > Alan Mackenzie writes: > >> (ii) In `parse-partial-sexp-continue-over-comment-marker', variable aftC > >> is the position in the middle of the comment closer "*/". I don't think > >> you are testing in any way that element 10 (nil, or the syntax of the > >> position just before the end point when that position might be the first > >> character of a two-character construct, i.e. an escape or first char of a > >> double-char comment delimiter) is correct. > > My idea was that its effect would be tested by using pps-preC as > > OLDSTATE, which avoids having to encode the specifics in the test. I > > added another clause which uses pps-aftC to cover parsing from the > > middle of a comment closer as well as opener. > Ping? Agree/Disagree? I've just had another fairly intensive look at the patches, and I agree. I think it's time to commit these. What do you say? -- Alan Mackenzie (Nuremberg, Germany).