From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dima@secretsauce.net, 25362@debbugs.gnu.org
Subject: bug#25362: 26.0.50; comment-region goes into an infinite loop
Date: Sat, 7 Jan 2017 10:27:10 +0000 [thread overview]
Message-ID: <20170107102709.GB3499@acm.fritz.box> (raw)
In-Reply-To: <83shovb3wd.fsf@gnu.org>
Hello, Eli.
On Sat, Jan 07, 2017 at 11:44:34AM +0200, Eli Zaretskii wrote:
> > Date: Sat, 7 Jan 2017 08:20:23 +0000
> > Cc: dima@secretsauce.net, 25362@debbugs.gnu.org
> > From: Alan Mackenzie <acm@muc.de>
> > There are actually two distinct bugs at work, here. One of them is
> > simple, the fix being merely giving a limit to an invocation of
> > c-forward-syntactic-ws.
> Does doing that prevent the infloop?
It prevents one infloop, but not the other one, which happens after the
first one is fixed.
> > The other bug is more involved. It involves the invalidation of the
> > whitespace cache, which is currently done incorrectly when "//" is
> > inserted into a line which already has comment markers later on that
> > line. It should be simple to fix, but is actually quite tricky, with a
> > likelihood of unwanted side effects if it's not done very carefully. I
> > might be able to fix it today, but I'm not certain of that.
> > I've done a bisection on the repository, and the commit that
> > "introduced" the bug didn't really introduce it at all - it merely
> > uncovered it. That commit was 4b9ac23960d2998f899287ffcf696ad33b63a69a
> > from 2016-07-03, "Speed up CC Mode fontification with less accurate
> > functions extending region".
> If no better solution emerges, would it make sense to revert 4b9ac23
> on the release branch, as a temporary workaround that prevents the
> infloop?
Apologies, that commit is only in master, not the emacs-25 branch. I'll
need to do some more careful bisection.
I'll get back to you later.
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-01-07 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 23:37 bug#25362: 26.0.50; comment-region goes into an infinite loop Dima Kogan
2017-01-05 20:54 ` Alan Mackenzie
2017-01-06 7:41 ` Eli Zaretskii
2017-01-06 9:32 ` Alan Mackenzie
2017-01-06 9:37 ` Eli Zaretskii
2017-01-06 9:41 ` Alan Mackenzie
2017-01-07 8:20 ` Alan Mackenzie
2017-01-07 9:44 ` Eli Zaretskii
2017-01-07 10:27 ` Alan Mackenzie [this message]
[not found] ` <20170107162907.GC3499@acm.fritz.box>
2017-01-07 16:31 ` Eli Zaretskii
2017-01-09 21:18 ` Alan Mackenzie
2017-01-09 21:46 ` Dima Kogan
2017-01-09 22:04 ` Alan Mackenzie
2017-01-11 18:32 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107102709.GB3499@acm.fritz.box \
--to=acm@muc.de \
--cc=25362@debbugs.gnu.org \
--cc=dima@secretsauce.net \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.