From: Olivier Certner <ocert.dev@free.fr>
To: "J.P." <jp@neverwas.me>
Cc: emacs-erc@gnu.org, 46775@debbugs.gnu.org
Subject: bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes
Date: Tue, 06 Jul 2021 18:34:48 +0200 [thread overview]
Message-ID: <2016416.4WAli8B44Z__14575.4779850662$1625589318$gmane$org@ravel> (raw)
In-Reply-To: <877dj3xk3e.fsf@neverwas.me>
> The updates to the doc string here are likewise superb and make things
> crystal clear.
Thanks!
> only 51% sure you meant s/necessary means/necessarily means/ in that
I fixed the typo in the updated patch.
> Regarding this module generally, it's definitely another one whose
> layout confuses me. For example, I guess we can't add keymaps to minor
> modes defined with `define-erc-module'? IOW, why the
> `erc-track-minor-mode-map' instead of a `erc-track-mode-map'?
The trick is that `erc-track-minor-mode' may be enabled or disabled
independently of the whole module. In particular, it may not be activated at
all if the (global) keybindings it wants to install, which don't abide by the
rules for minor modes maps, are already bound at the time of module's
activation.
> I'm also confused by the 001 RPL_WELCOME hook, but for now, I'll just assume
> it's a vestige of a simpler time when `erc-user-is-active' looked different
> and maybe did more. Or (more likely) there's something I'm not seeing
> just yet.
`erc-user-is-active' seems in fact to be used for more than one purpose. In
particular, it also triggers an update of channels in the mode line. What's
exactly the problem with hooking on 001?
> Anyway, I mention this stuff because you may be the best/only
> qualified person to address such concerns at present. Would you be
> willing to audit this file for redundancy/cruft/obsolescence at some
> point before the next release? Thanks.
Depending on available time and precise concerns that you may have, yes.
There is a lot of room for improvement in this module. In particular in
determining how some user is "active" (none of the current possibilities
really suits my needs).
--
Olivier Certner
next prev parent reply other threads:[~2021-07-06 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 17:14 bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes Olivier Certner
2021-02-25 17:24 ` Olivier Certner
2021-02-26 8:51 ` Lars Ingebrigtsen
2021-02-26 9:03 ` Olivier Certner
2021-06-09 13:07 ` J.P.
2021-07-06 14:23 ` bug#46775: Updated patches Olivier Certner
2021-09-12 5:25 ` bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes Amin Bandali
[not found] ` <877dj3xk3e.fsf@neverwas.me>
2021-07-06 16:34 ` Olivier Certner [this message]
[not found] ` <2016416.4WAli8B44Z@ravel>
2021-07-07 12:30 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='2016416.4WAli8B44Z__14575.4779850662$1625589318$gmane$org@ravel' \
--to=ocert.dev@free.fr \
--cc=46775@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.