From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#25265: [PATCH] Rework NS event handling (bug#25265) Date: Sat, 31 Dec 2016 16:46:02 +0000 Message-ID: <20161231164602.GA29157@breton.holly.idiocy.org> References: <83vau0h2u5.fsf@gnu.org> <20161231160930.GA29122@breton.holly.idiocy.org> <83lguwgj55.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1483202837 6116 195.159.176.226 (31 Dec 2016 16:47:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 16:47:17 +0000 (UTC) User-Agent: Mutt/1.7.1 (2016-10-04) Cc: charles@aurox.ch, 25265@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 31 17:47:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNMoH-0000No-Ux for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 17:47:10 +0100 Original-Received: from localhost ([::1]:44750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNMoJ-00066I-SA for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 11:47:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNMoD-00066D-ND for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:47:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNMoA-00074u-Hn for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:47:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNMoA-00074q-EQ for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cNMo9-00085q-N5 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 11:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2016 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25265 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25265-submit@debbugs.gnu.org id=B25265.148320277231048 (code B ref 25265); Sat, 31 Dec 2016 16:47:01 +0000 Original-Received: (at 25265) by debbugs.gnu.org; 31 Dec 2016 16:46:12 +0000 Original-Received: from localhost ([127.0.0.1]:33419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNMnL-00084i-Mc for submit@debbugs.gnu.org; Sat, 31 Dec 2016 11:46:11 -0500 Original-Received: from mail-wj0-f176.google.com ([209.85.210.176]:35871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNMnK-00084W-9j for 25265@debbugs.gnu.org; Sat, 31 Dec 2016 11:46:10 -0500 Original-Received: by mail-wj0-f176.google.com with SMTP id c11so192593384wjx.3 for <25265@debbugs.gnu.org>; Sat, 31 Dec 2016 08:46:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bghEoNItVLviKBwmzNIlYfR2cOuumGMyv8IZneuPV0o=; b=FmTDFE5He2OhQo2ltV2fpNvrhiVNCdDNMle+CwTTQIKJnaw5CSwzo9Ak0gn1whl3Wm FicLwNXp5K54e6amuk1gTdyJz0R+W7gxBC27uNO1DaVL3dZZhEzuicg7oscyWzzhrQcD RshT+FjAa6h6RQJDfh+8JPCjaXYe1hPKX//MJV3faGvfn1tqnt3Kk48hAOLgtDeN3NPB qzWLDh2KhSOKEVebENFmtpZh3ccPyx5Bs0Bo7gCdrpUFOOtxPOqXzKoJSc5Z1kwjylZ9 +A1yWESoRbN66EoqWQwHy9cge6mGIKcqc3ElkuYHaSyeejb3LRMuprMfSsYaNP78FEPx a1Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=bghEoNItVLviKBwmzNIlYfR2cOuumGMyv8IZneuPV0o=; b=pZc/hved7A0uv1CaPTIOwcTOblYCVuSO4gHOQwWQrWXaJkv6GAejFfunQeVfTMXFVi REd7a0hlUgb8Eg+ba+6xs+ReGKPdgHyTfqXkz8fYolkSCtjmf9gA20bYg1jfOjs42HOD FIqId62VwVkM5uoGy4gs+aTmHUOsvEHsfUKGBfIk1FPA/FpUrDXriAS4A7plK7pdX1SY Qj2jKUbHyGsuV+nkKGAYv5+GwOllfqgciZQ89tcAbjdlcJjhNN0PLGcO+4fRy+eQC9tS jR9wxhOhEemB/iYaK2Fi5+ELI1MnAZCAxaX2AeN8bcAmROlRxrX7fAiN4uJ9xf0dtmrX PSTg== X-Gm-Message-State: AIkVDXJcohRHAZMRUwB5HbnRDw8w84jzHf5RX1Z8ohubLF6XRMynoeWnQNFxnKi83+q0kg== X-Received: by 10.195.12.99 with SMTP id ep3mr37024807wjd.222.1483202764426; Sat, 31 Dec 2016 08:46:04 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-fcf8-7042-dd5f-6680.holly.idiocy.org. [2001:8b0:3f8:8129:fcf8:7042:dd5f:6680]) by smtp.gmail.com with ESMTPSA id ke6sm79126045wjb.21.2016.12.31.08.46.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Dec 2016 08:46:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <83lguwgj55.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127633 Archived-At: On Sat, Dec 31, 2016 at 06:25:58PM +0200, Eli Zaretskii wrote: > > Date: Sat, 31 Dec 2016 16:09:30 +0000 > > From: Alan Third > > Cc: charles@aurox.ch, 25265@debbugs.gnu.org > > > > Here we go. This seems to work. It turns out there are trade‐offs > > between the GUI and network performance. If I remove > > NSApp:nextEventMatchingMask from ns_select, eww loads web pages > > *significantly* faster, but the scrollbars become effectively > > unusable. > > Wow, thanks a lot! > > I cannot review the patch, as I don't really understand the details. > So I suggest to push this and see if users report bugs. I forgot to say before, I think there may be slightly more lag then before when using the scroll bars. I don’t really use them so I don’t know if people will be bothered by it. With NSTrace turned on I can actually crash Emacs by waving the scroll bars about, but I can’t with NSTrace off. Everything else seems fast enough. If I push it I suppose we’ll find out soon enough if it’s acceptable. > (I presume you have run all the tests, including those in > test/src/thread-tests.el and those posted in the few recent > discussions related to thread-related problems. If not, I very much > recommend that you do that, to see if the new code passes these > "entry-level" tests.) I hadn’t, but I have now. Make check reports 3 unexpected results as usual, and the log for thread-tests.el shows 27/27 passed. I tried this from one of the other threads (I’ve not looked through them completely yet): (dotimes (x 10) (make-thread (lambda () (let ((n (random 10))) (with-current-buffer "z" (sleep-for n) (insert (format "Foo:%d\n" n))))))) and it seems to do what it’s supposed to do. -- Alan Third