From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Stefan-W. Hahn" Newsgroups: gmane.emacs.bugs Subject: bug#25246: 25.1.90; Buffer not responsible with overlay at buffer end. Date: Fri, 23 Dec 2016 14:36:47 +0100 Organization: -no organization- Message-ID: <20161223133647.GE5148@seven> References: <20161222091305.GC5148@seven> <83bmw328uy.fsf@gnu.org> <87wpera4y3.fsf@users.sourceforge.net> <20161223073315.GD5148@seven> <83tw9vypab.fsf@gnu.org> <83r34yzyuu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1482500296 13925 195.159.176.226 (23 Dec 2016 13:38:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2016 13:38:16 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: 25246@debbugs.gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 23 14:38:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKQ30-0002qW-6k for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 14:38:10 +0100 Original-Received: from localhost ([::1]:39258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKQ34-0001lD-Ue for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 08:38:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKQ2x-0001kx-Pn for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 08:38:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKQ2s-0007uW-U1 for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 08:38:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36731) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKQ2s-0007uS-Q7 for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 08:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKQ2s-0006xv-Hs for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 08:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Stefan-W. Hahn" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Dec 2016 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25246 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 25246-submit@debbugs.gnu.org id=B25246.148250023126706 (code B ref 25246); Fri, 23 Dec 2016 13:38:02 +0000 Original-Received: (at 25246) by debbugs.gnu.org; 23 Dec 2016 13:37:11 +0000 Original-Received: from localhost ([127.0.0.1]:52130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKQ23-0006wf-Md for submit@debbugs.gnu.org; Fri, 23 Dec 2016 08:37:11 -0500 Original-Received: from mout.kundenserver.de ([212.227.126.133]:63252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKQ21-0006wS-RK for 25246@debbugs.gnu.org; Fri, 23 Dec 2016 08:37:10 -0500 Original-Received: from seven.home ([92.193.87.157]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.167]) with ESMTPSA (Nemesis) id 0Lf3PM-1cvvcu3e92-00omdl; Fri, 23 Dec 2016 14:36:49 +0100 Original-Received: from seven.home (localhost [127.0.0.1]) by seven.home (8.15.2/8.15.2/Debian-3) with ESMTPS id uBNDalRi002198 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Dec 2016 14:36:47 +0100 Original-Received: (from hs@localhost) by seven.home (8.15.2/8.15.2/Submit) id uBNDalSn002197; Fri, 23 Dec 2016 14:36:47 +0100 X-Authentication-Warning: seven.home: hs set sender to stefan.hahn@s-hahn.de using -f Content-Disposition: inline In-Reply-To: <83r34yzyuu.fsf@gnu.org> X-Mailer: Mutt http://www.mutt.org/ X-Editor: GNU Emacs http://www.gnu.org/ X-Accept-Language: de en X-Location: Europe X-GPG-Public-Key: gpg --keyserver pool.sks-keyservers.net --recv-keys 7A948D9CB5F0706D X-GPG-Fingerprint: 0x7A948D9CB5F0706D / 270E F64C 748A E880 9CB7 3D9B 7A94 8D9C B5F0 706D X-Virus-Scanned: clamav-milter 0.99.2 at seven X-Virus-Status: Clean X-Provags-ID: V03:K0:t+qNnLBpejwZM/bEhUIiXFMF+RT9DiTLFG0oGqTnJF3fJ22vyGH Qd8m4pjECIOP11SyCBhs1zK9ppbWRfgfkKt7fkvKDk36Ga71DruT73kEgO6dCvQa2vcqS2H 0ZIWP8IUNazqN/f7ANOSLXnsYSyl6pPdF9N0SQV/5UK13wCisnam7z5DKdZiPBUpqJKfA/5 pa0m6cxGnkdmlx2d/cS3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:/Vn5U2JYEL0=:xCoaj/jlO0TU+XF4KiNR1Q /Ae0YMx3Vq7V7cBK4RzgSdDBIOcSFvCvLMTDhvC9CERSEb0zlwKigaiG3MEr6nsUnGB2dDGvy Pa1TMt3DwKGkJzQNU1w1YxmhDqE1+QJsoeIhPm5KWltMFYtZ8xyPCvTx1I+m7g6061V0RYEUq BtXUbkYaMEwBpILnedCKwVAUVqZaS72rSKlRr6SHd5IVOpyjxCfccKZiNouVlH3hYJZ99jdZk YmKb6YpJKtWjON7tMV8c4WltQFiIAbbgU0ETU7qrYhGhMFUORJbDKSPb718vd0KSgGI3f+rHS WnjzFLdWGPhDJqXLNTwArQKDCsgC2VxAk1sXciuiMs2B3myAXq2QMC0W8IG+ZfhUl1X+3THCK bfB5WCKwWhTIi1aP2+0cmwODXsNO/YwaNjfygBOu7i9Pi30pePbVWdpyh5fvbpO7x+tTJou88 AWuH/bjlwTCGRr06ij6YDOw38oqPxv7ClOWPzhcxbq/nXA6GVgUs6lmiMW7goA1byhar8s8VK RAfbnZHH50d4FEfUKCWV4uepYP/Ih8EtbkD98ehAbWQNTnVv2adij0G9eRWtUDF/2wn8PSTw5 LmlyJeHkc4hNvPyiLOhgswVJ4a9WzmxS1ploScX9I5JQZ8WxmQEE91c25Inj0AbrG37S4JYfp uwjj0m+HEzGFNNWHHUc+HBl2LRcaJGujpmqmnu1RG2le0ZQGdlE1d+7APhn21AvELXq8= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127363 Archived-At: Mail von Eli Zaretskii, Fri, 23 Dec 2016 at 13:08:57 +0200: Hello, > If the change below, when applied to the master branch, gives good > results, I will install it. tried this on Linux and Windows. Works really good. > The results as I see after this change are not ideal (you cannot see > the entire overlay string, unless you manually hscroll the window with > "C-x >", and the cursor at EOB is not visible). But at least the loop That is no problem, because the overlay moves if compilation proceeds and the compilation buffer gets more content. The problem only arises if a single line of output in compilation buffer was bigger then the screen width (and I have truncates-lines set to t) and had no LF. In all other cases there was no problem. I saw this just now,, because our production environment is producing such long lines since not so long time. > is avoided, AFAICT, and there's only one "blink" of incorrect display. > Is this satisfactory enough to install this simple change? As said. It works very well. Thank you. With kind regards, Stefan > > Thanks. > > diff --git a/src/xdisp.c b/src/xdisp.c > index ad0b968..37ca81d 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -13049,6 +13049,17 @@ hscroll_window_tree (Lisp_Object window) > init_to_row_start (&it, w, cursor_row); > it.last_visible_x = INFINITY; > move_it_in_display_line_to (&it, pt, -1, MOVE_TO_POS); > + /* If the line ends in an overlay string with a newline, > + we might infloop, because displaying the window will > + want to put the cursor after the overlay, i.e. at X > + coordinate of zero on the next screen line. So we > + use the buffer position prior to the overlay string > + instead. */ > + if (it.method == GET_FROM_STRING && pt > 1) > + { > + init_to_row_start (&it, w, cursor_row); > + move_it_in_display_line_to (&it, pt - 1, -1, MOVE_TO_POS); > + } > current_buffer = saved_current_buffer; > > /* Position cursor in window. */ > -- Stefan-W. Hahn It is easy to make things. It is hard to make things simple.