bug#25217: [PATCH] Enable sh-mode zshrc

bug#25217: [PATCH] Enable sh-mode zshrc

[Michihito Shigemura]

* lisp/progmodes/sh-script.el (sh-mode):
Add zsh string-match
---
 lisp/progmodes/sh-script.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5d362e4..ac5fb19 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1683,6 +1683,7 @@ sh-mode
          ((string-match "[.]bash\\>"   buffer-file-name) "bash")
          ((string-match "[.]ksh\\>"    buffer-file-name) "ksh")
          ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
+         ((string-match "[.]zsh\\(rc\\)?\\>" buffer-file-name) "zsh")
 	 ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
          (t sh-shell-file))
    nil nil)
-- 
2.9.3

bug#25217: [PATCH] Enable sh-mode zshrc

[Alan Third]

Michihito Shigemura <m_shigemura@shigemk2.com> writes:

> * lisp/progmodes/sh-script.el (sh-mode):
> Add zsh string-match
> ---
>  lisp/progmodes/sh-script.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
> index 5d362e4..ac5fb19 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -1683,6 +1683,7 @@ sh-mode
>           ((string-match "[.]bash\\>"   buffer-file-name) "bash")
>           ((string-match "[.]ksh\\>"    buffer-file-name) "ksh")
>           ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
> +         ((string-match "[.]zsh\\(rc\\)?\\>" buffer-file-name) "zsh")
>  	 ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
>           (t sh-shell-file))
>     nil nil)

Hi, looks good.

Is it worth adding support for .zshenv as well?
-- 
Alan Third

bug#25217: (no subject)

[Michihito Shigemura]

Thank you for your replying.

I can add support for .zshenv. But how can I send the improved patch?

Do I send it to 25217 at debbugs.gnu.org?

bug#25217: (no subject)

[Alan Third]

On Mon, Dec 19, 2016 at 10:15:56PM +0900, Michihito Shigemura wrote:
> Thank you for your replying.
> 
> I can add support for .zshenv. But how can I send the improved patch?
> 
> Do I send it to 25217 at debbugs.gnu.org?

Yes, thanks.
-- 
Alan Third

bug#25217: [PATCH] Enable sh-mode zshrc

[Michihito Shigemura]

* lisp/progmodes/sh-script.el (sh-mode):
Add zsh string-match
---
 lisp/progmodes/sh-script.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5d362e4..a2c869d 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1683,6 +1683,7 @@ sh-mode
          ((string-match "[.]bash\\>"   buffer-file-name) "bash")
          ((string-match "[.]ksh\\>"    buffer-file-name) "ksh")
          ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
+         ((string-match "[.]zsh\\(rc\\|env\\)?\\>" buffer-file-name) "zsh")
 	 ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
          (t sh-shell-file))
    nil nil)
-- 
2.9.3

bug#25217:

[Michihito Shigemura]

I sent new patch!

bug#25217:

[Alan Third]

On Fri, Dec 23, 2016 at 01:07:04PM +0900, Michihito Shigemura wrote:
> I sent new patch!

Sorry for the slow response. It looks good to me. Have you contributed
to Emacs before?
-- 
Alan Third

bug#25217:

[Michihito Shigemura]

Sorry, but I haven't contributed to Emacs before.

bug#25217:

[Alan Third]

On Sat, Dec 24, 2016 at 11:11:10PM +0900, Michihito Shigemura wrote:
> Sorry, but I haven't contributed to Emacs before.

That’s good. If you had contributed before we might have had to get
you to assign copyright, but since it’s a small change we can let it
go. If you do decide to contribute again in the future you may have to
go through the process of assigning copyright.

I’ve pushed this change to the master branch.

Thank you!
-- 
Alan Third

bug#25217: (no subject)

[Michihito Shigemura]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

> That’s good. If you had contributed before we might have had to get
you to assign copyright, but since it’s a small change we can let it
go. If you do decide to contribute again in the future you may have to
go through the process of assigning copyright.

Thank you for your pushing my change. I'll be careful.


[-- Attachment #2: Type: text/html, Size: 1048 bytes --]