From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#25219: 26.0.50; ispell failing Date: Sun, 18 Dec 2016 16:08:40 +0000 Message-ID: <20161218160840.GA56991@breton.holly.idiocy.org> References: <83vauh5kqw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1482077354 14136 195.159.176.226 (18 Dec 2016 16:09:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Dec 2016 16:09:14 +0000 (UTC) User-Agent: Mutt/1.7.1 (2016-10-04) Cc: 25219-done@debbugs.gnu.org, rrt@sc3d.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 18 17:09:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIe1L-0002fM-St for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Dec 2016 17:09:08 +0100 Original-Received: from localhost ([::1]:41240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIe1Q-0003Fi-Ag for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Dec 2016 11:09:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIe1J-0003Dp-2k for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2016 11:09:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIe1F-0005HX-UU for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2016 11:09:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIe1F-0005HR-R3 for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2016 11:09:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cIe1F-0001Ha-MH for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2016 11:09:01 -0500 Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2016 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 25219@debbugs.gnu.org, alan@idiocy.org, jpff@birtwistle.i-did-not-set--mail-host-address--so-tickle-me Original-Received: via spool by 25219-done@debbugs.gnu.org id=D25219.14820773324909 (code D ref 25219); Sun, 18 Dec 2016 16:09:01 +0000 Original-Received: (at 25219-done) by debbugs.gnu.org; 18 Dec 2016 16:08:52 +0000 Original-Received: from localhost ([127.0.0.1]:46294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIe16-0001H7-LX for submit@debbugs.gnu.org; Sun, 18 Dec 2016 11:08:52 -0500 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:37011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIe14-0001Gt-VC for 25219-done@debbugs.gnu.org; Sun, 18 Dec 2016 11:08:51 -0500 Original-Received: by mail-wm0-f46.google.com with SMTP id t79so80811363wmt.0 for <25219-done@debbugs.gnu.org>; Sun, 18 Dec 2016 08:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CzZbieaCfvw6tFU1VZYPKS2Pa+xu9cUAx2KIyiY7E64=; b=RX/6rpPL35644aCVhdxOkbbCzenMOm3kFFLaI91uGgqQQphzB2xEbL8p89/7kVlBFH WsQuPvrX4+1ysnmo0SwBKBi/LIz0LWQ7tNWzPiULG5Pep/2Z7oJ0uH+2C1jDeTic2zUS BnZgLrYPvp61QMuoCFzGL49CR7gbcj8cHMVjWpzbMD4x8S5rtNlGYkRlS+/cfArs9hRo XQ1bKR/iXNxCJj8s4nUfYOZNs37b55q0P3rKdnf8hzwRmq7HDiviYNfDM1GilNiHclf6 nBCB9BVHxszunW0FmOxbhx6NbVZflRrAoC4BlyPZzMHsPqVnE+C8XJT22kz177UxItK5 SpJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=CzZbieaCfvw6tFU1VZYPKS2Pa+xu9cUAx2KIyiY7E64=; b=rGvTOTCe2hF+cuNFs/0OnMiGJOW8bBF67bbK8yoNIwLcENqvZ5uL5BgLF883BO9AR2 4EqTX0hhxeYFDHn/LQQlZcsJ1IN0R/JlfKf6csZbFqHzAHmC1W1QmMKP8eWAmOLqvAiK rk2KmF/Z1bUD1f4F3cuBJPcNx3Nz8Th0tosl9bdBx+SrZCXq+OHtNxnGCMlAgh+YgAU7 gw/y6F2IuwMzhBZoRpD0hSIipKjndAESVbDnz1rRWjdrrvhyvczTIVhuaNaHOZ6xkDpS hGeAF2hbSnt/pntIZ1RGCqhtaEkvqGAQkCbNdxuV5eQ4SB4BZW8tm1c+95mvcMhIkq01 aR1w== X-Gm-Message-State: AIkVDXJxhEO6kg+DIKys5yDv5nA/9On7xjIhL0jsL15YmpuxBbc71w0wKttQLcjPEQ3bFg== X-Received: by 10.28.40.67 with SMTP id o64mr9879305wmo.40.1482077325284; Sun, 18 Dec 2016 08:08:45 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-f570-80e4-3e8c-1ced.holly.idiocy.org. [2001:8b0:3f8:8129:f570:80e4:3e8c:1ced]) by smtp.gmail.com with ESMTPSA id ab10sm16553171wjc.45.2016.12.18.08.08.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Dec 2016 08:08:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <83vauh5kqw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127130 Archived-At: On Sun, Dec 18, 2016 at 05:18:15PM +0200, Eli Zaretskii wrote: > > From: Alan Third > > Date: Sun, 18 Dec 2016 11:51:37 +0000 > > Cc: 25219@debbugs.gnu.org > > > > > run M-x ispell-buffer > > > > > > watch it fail on fist word not in dictionry > > > > > > I use ispell before sending mail (dyslexia and sspect keyboad) > > > > > > een this way fo a week or so > > > > It looks like this started with commit: > > > > db6e1f82976a7f232a4a206a3c850ed34cfbfdd3 > > > > The following patch appears to fix the problem for me, but I have my > > doubts it's the best way to handle it and I've only tested with > > hunspell. > > > > modified lisp/textmodes/ispell.el > > @@ -3338,7 +3338,7 @@ ispell-process-line > > ;; Markers can move with highlighting! This destroys > > ;; end of region markers line-end and ispell-region-end > > (let ((word-start > > - (copy-marker (+ ispell-start (car (cdr poss))))) > > + (copy-marker (+ ispell-start -1 (car (cdr poss))))) > > (word-len (length (car poss))) > > (line-end (copy-marker ispell-end)) > > (line-start (copy-marker ispell-start)) > > > > Any thoughts? > > We definitely need to keep the -1 offset there. (It was previously > supplied by ispell-offset, but that variable was deleted.) The reason > for the offset is that the line we send to the speller has a "^" > prepended to it (see the documentation of the Ispell interface for the > reason why). > > Please add a comment to that effect when you commit the above. Done. Thanks! -- Alan Third