From: Alan Mackenzie <acm@muc.de>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 24870@debbugs.gnu.org, Matt Armstrong <marmstrong@google.com>
Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end
Date: Thu, 15 Dec 2016 16:44:58 +0000 [thread overview]
Message-ID: <20161215164458.GA2437@acm.fritz.box> (raw)
In-Reply-To: <CAM-tV-9_dBxDwtdhQFKFz8JTzyDSZJc4GafuKuJVi6kuVUcxJw@mail.gmail.com>
Hello, Noam.
On Thu, Dec 15, 2016 at 11:33:36AM -0500, Noam Postavsky wrote:
> On Wed, Dec 14, 2016 at 4:58 PM, Alan Mackenzie <acm@muc.de> wrote:
> > Alas, that patch won't do.
> I thought that might be the case.
> > What is new here is characters with paren syntax also being components of
> > 2-char comment delimiters. I recently fixed a similar problem when
> > characters with word syntax were also flagged as 2-char comment delimiter
> > parts. I think a similar patch at case label Sopen: (Line ~3322), which
> > would peek ahead at the next character to check for "{-" before
> > recognising the "{" as an open paren would be the best fix.
> I don't think special casing Sopen makes sense, shouldn't the check
> apply to all syntax classes?
Maybe. I'm too tired to work this out at the moment (it was the office
Glühwein day).
> (the special case for word syntax does make sense, because it has its
> own inner loop already)
As does comment syntax, of course.
> > Do you want to make this fix, or should I do it? If you want to do it,
> > I'm willing (indeed, eager) to review it for you.
> I'll have a patch ready in a day or two.
Excellent! Or even in three or four days. Take your time, do it well
(at least, better than I managed last time round) and enjoy doing it.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-12-15 16:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 19:38 bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Andreas Röhler
2016-11-30 9:10 ` Matt Armstrong
2016-11-30 12:37 ` Andreas Röhler
2016-11-30 23:02 ` Matt Armstrong
2016-12-01 1:17 ` npostavs
2016-12-01 8:24 ` Andreas Röhler
2016-12-14 3:00 ` npostavs
2016-12-14 4:04 ` npostavs
2016-12-14 6:45 ` Andreas Röhler
2016-12-14 19:56 ` Alan Mackenzie
2016-12-15 8:18 ` Andreas Röhler
2016-12-15 16:01 ` Eli Zaretskii
2016-12-15 16:50 ` Alan Mackenzie
2016-12-15 17:59 ` Andreas Röhler
2016-12-14 21:58 ` Alan Mackenzie
2016-12-15 16:33 ` Noam Postavsky
2016-12-15 16:44 ` Alan Mackenzie [this message]
2016-12-18 5:39 ` npostavs
2016-12-29 11:14 ` Alan Mackenzie
2016-12-30 1:55 ` npostavs
2017-01-13 2:07 ` npostavs
2017-01-23 20:12 ` Alan Mackenzie
2017-01-24 0:30 ` npostavs
2016-12-01 8:33 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215164458.GA2437@acm.fritz.box \
--to=acm@muc.de \
--cc=24870@debbugs.gnu.org \
--cc=marmstrong@google.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.