From: Alan Mackenzie <acm@muc.de>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Checking in files with trailing white space
Date: Tue, 13 Dec 2016 18:28:22 +0000 [thread overview]
Message-ID: <20161213182822.GA2705@acm.fritz.box> (raw)
In-Reply-To: <cd2ee9b5-e174-21b3-ba03-9585924143b8@cs.ucla.edu>
Hello, Paul.
On Mon, Dec 12, 2016 at 02:57:42PM -0800, Paul Eggert wrote:
> On 12/12/2016 02:16 PM, Alan Mackenzie wrote:
> > However, this absolute prohibition on trailing spaces is fascistic.
> > Some files (for example, test files) have essential trailing spaces in
> > them
> I added a comment to the pre-commit file to help out others in your
> situation; see the attached patch.
Thanks. That looks just the job!
> As it is all too easy to overlook trailing white space when reading
> source code, I'd rather avoid having significant whitespace in committed
> files. If I were writing those test cases, I'd commit files that didn't
> have trailing whitespace, and convert them to
> files-with-trailing-whitespace while running the test.
Alternatively, could the pre-commit git hook be adapted to warn the
committer about trailing space and ask him for confirmation? I couldn't
see an easy way over the weekend, but it might be possible, somehow.
[ .... ]
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-12-13 18:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 12:55 Checking in files with trailing white space Lars Magne Ingebrigtsen
2016-03-20 13:08 ` Lars Magne Ingebrigtsen
2016-12-11 13:31 ` Alan Mackenzie
2016-12-11 18:50 ` Lars Ingebrigtsen
2016-12-12 22:16 ` Alan Mackenzie
2016-12-12 22:57 ` Paul Eggert
2016-12-13 3:32 ` Eli Zaretskii
2016-12-13 7:31 ` Paul Eggert
2016-12-13 16:01 ` Eli Zaretskii
2016-12-13 18:33 ` Paul Eggert
2016-12-13 19:00 ` Eli Zaretskii
2016-12-13 22:39 ` Paul Eggert
2016-12-14 3:31 ` Eli Zaretskii
2016-12-14 7:47 ` Paul Eggert
2016-12-14 15:32 ` Eli Zaretskii
2016-12-14 18:15 ` Paul Eggert
2016-12-14 19:26 ` Eli Zaretskii
2016-12-13 18:28 ` Alan Mackenzie [this message]
2016-12-13 18:39 ` Paul Eggert
2016-03-21 13:10 ` Stefan Monnier
2016-03-21 13:59 ` Lars Magne Ingebrigtsen
2016-03-21 18:09 ` Paul Eggert
2016-04-04 20:05 ` Lars Magne Ingebrigtsen
2016-04-04 21:55 ` Paul Eggert
2016-04-24 13:13 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213182822.GA2705@acm.fritz.box \
--to=acm@muc.de \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.