From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Sun, 4 Dec 2016 12:34:34 +0000 Message-ID: <20161204123434.GB2791@acm.fritz.box> References: <878trydrbo.fsf@red-bean.com> <83a8cem1eq.fsf@gnu.org> <83zikdl7oo.fsf@gnu.org> <83y3zxkwms.fsf@gnu.org> <20161203143603.GA6921@acm.fritz.box> <43e8a279-3278-817b-7cd4-b669c5ae320b@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1480854938 15657 195.159.176.226 (4 Dec 2016 12:35:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Dec 2016 12:35:38 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 04 13:35:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDW10-0003Mu-6r for ged-emacs-devel@m.gmane.org; Sun, 04 Dec 2016 13:35:34 +0100 Original-Received: from localhost ([::1]:34157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDW13-0000qh-Tl for ged-emacs-devel@m.gmane.org; Sun, 04 Dec 2016 07:35:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDW0U-0000qO-Jm for emacs-devel@gnu.org; Sun, 04 Dec 2016 07:35:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDW0O-0002Dz-9x for emacs-devel@gnu.org; Sun, 04 Dec 2016 07:35:02 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:52921 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cDW0N-0002Dl-V6 for emacs-devel@gnu.org; Sun, 04 Dec 2016 07:34:56 -0500 Original-Received: (qmail 84912 invoked by uid 3782); 4 Dec 2016 12:34:55 -0000 Original-Received: from acm.muc.de (p548C7677.dip0.t-ipconnect.de [84.140.118.119]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 04 Dec 2016 13:34:54 +0100 Original-Received: (qmail 3958 invoked by uid 1000); 4 Dec 2016 12:34:34 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210016 Archived-At: On Sat, Dec 03, 2016 at 04:09:24PM -0500, Stefan Monnier wrote: > >> I'd forgotten about that patch. It's further evidence of the trouble > >> lurking here. How about landing that code now? > > How about not being rash and reading up on the conversations that ended in > > that patch not being applied? > Or applying the patch I suggested instead (much simpler and leverages > the syntax-ppss cache)... Your patch was indeed simpler. Indeed, it was so simple as actually not to work in general, as well as being ~2 orders of magnitude slower than the current (forward-comment -1). syntax-ppss is broken (bug #22983) and has been for many years, so to base a critical primitive on it seems unwise. And one or two other things, too. Other than that, yes we could apply that patch. BTW, I've been looking at bug #22983 the last few days, since it seems nobody else is going to bother fixing it. > Stefan -- Alan Mackenzie (Nuremberg, Germany).