From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972) Date: Wed, 23 Nov 2016 12:01:50 -0500 Message-ID: <20161123170150.GA954@holos.localdomain> References: <20161122074808.5832.60015@vcs.savannah.gnu.org> <20161122074808.974112201C5@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1479920895 12121 195.159.176.226 (23 Nov 2016 17:08:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 Nov 2016 17:08:15 +0000 (UTC) User-Agent: Mutt/1.7.1+41 (5382e1e4cee1) (2016-10-04) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 23 18:08:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9b1k-0002Ed-J3 for ged-emacs-devel@m.gmane.org; Wed, 23 Nov 2016 18:08:08 +0100 Original-Received: from localhost ([::1]:35049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9b1o-00046F-15 for ged-emacs-devel@m.gmane.org; Wed, 23 Nov 2016 12:08:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9avl-0007sh-El for emacs-devel@gnu.org; Wed, 23 Nov 2016 12:01:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9avh-0000Fx-6C for emacs-devel@gnu.org; Wed, 23 Nov 2016 12:01:57 -0500 Original-Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:36467) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9avh-0000FR-22 for emacs-devel@gnu.org; Wed, 23 Nov 2016 12:01:53 -0500 Original-Received: by mail-qk0-x235.google.com with SMTP id n21so21781254qka.3 for ; Wed, 23 Nov 2016 09:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fRN5Fgf/HkL0iWebwyehyP99Ex7X2EhpuVMwHYnWF7w=; b=QqniM7dEyhMV/j5ez5TAtyC8UMHMcn0DoJ0PemMYzS/lJ1AhmU89Yrk0D54PDb06Ka oIQV7Cqe+lJF/wT0HYdPrQZefwyTbRncmY55l34L2HrFSyVHGfXwRqlXPUlLYqi+V5kr vxGBYMqfAmhDkIQBFlr33bH3BKhXUdXDZBuqcqg/DJjUky7dtT6m3uLneNfoDucaSkU0 5ud2+b8RK5IGrg1NnLLVsG6jKtAuzvbZ8fUgdaZjpVu9SzBP9ionKfuFwZYAw7QzIl8g ZsfIJblGzi1CU3jhbF/K0vw4hioI1c49qwZxcYEYnSjX1ghzEFiHNufLjBX3lvzNRcdr MvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fRN5Fgf/HkL0iWebwyehyP99Ex7X2EhpuVMwHYnWF7w=; b=jT6jiBVsa07HnCaEKiQwdOOjZoN6oWJiNkj9rxv5q0E9GRmc/90XgGw20xIWRo2BzG ELDpQn1ir8u/T9PqVcBPEZAcKqnZeo7fviueGYYmY6ji8CGE2Ya2d45VX53gdw6rHYmS Tef48rrTrljVW+6pxA3m3h4r7laCVG5CnMGwC8zcq7fw0oNnBF5w0yZVGAia1DkdzxLO 0N6fbYpaAh3CP4HAl8XvcvC6kyUft5d1s1dnt/Vv8lxcRQm57ZFyC8L310XwHq2OCTnU iuI+gOT7QU4R3By/Fy/UebSpGGclCJ8+ROt/AFuX6mO3hw9FShG77555I7SnIl/imcLz Dulw== X-Gm-Message-State: AKaTC01BEL0iJFIiKh/k24RKuRpt772sfKolQwcrotmNCWprrHy56vPSKeHpdLT1cI43Surg X-Received: by 10.55.7.17 with SMTP id 17mr4337509qkh.228.1479920511941; Wed, 23 Nov 2016 09:01:51 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id g97sm6942742qkh.11.2016.11.23.09.01.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 09:01:51 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id C5B716840F; Wed, 23 Nov 2016 12:01:50 -0500 (EST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209571 Archived-At: On 22/11/16 at 08:17am, Stefan Monnier wrote: > > - `(truncate-string-to-width > > - ,strvar strlen nil nil > > - ,ellipsis)) > > + `(concat > > + (truncate-string-to-width > > + ,strvar (- strlen (string-width ,ellipsis)) nil ?.) > > + ,ellipsis)) > > Hmm... why was this needed? > > > Stefan "maybe it should be fixed in truncate-string-to-width instead" Your guess would probably be better than mine. Perhaps I needed to /add/ the length of the ellipsis to strlen in the removed code? I was quite ready to rip my hair out trying to make sense of all that ibuffer machinery. Horribly untestable the way it's written as well.