all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972)
Date: Wed, 23 Nov 2016 12:01:50 -0500	[thread overview]
Message-ID: <20161123170150.GA954@holos.localdomain> (raw)
In-Reply-To: <jwvpoln3b8t.fsf-monnier+emacsdiffs@gnu.org>

On 22/11/16 at 08:17am, Stefan Monnier wrote:
> > -		`(truncate-string-to-width
> > -		  ,strvar strlen nil nil
> > -		  ,ellipsis))
> > +		`(concat
> > +		  (truncate-string-to-width
> > +                   ,strvar (- strlen (string-width ,ellipsis)) nil ?.)
> > +                  ,ellipsis))
> 
> Hmm... why was this needed?
> 
> 
>         Stefan "maybe it should be fixed in truncate-string-to-width instead"

Your guess would probably be better than mine.  Perhaps I needed to
/add/ the length of the ellipsis to strlen in the removed code?  I was
quite ready to rip my hair out trying to make sense of all that ibuffer
machinery.  Horribly untestable the way it's written as well.



      reply	other threads:[~2016-11-23 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161122074808.5832.60015@vcs.savannah.gnu.org>
     [not found] ` <20161122074808.974112201C5@vcs.savannah.gnu.org>
2016-11-22 13:17   ` [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972) Stefan Monnier
2016-11-23 17:01     ` Mark Oteiza [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123170150.GA954@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.