From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24 Date: Tue, 15 Nov 2016 09:06:06 -0700 Message-ID: <20161115160606.autvngpkpxuvbpyv@iris.silentflame.com> References: <20161115040050.3382-1-spwhitton@spwhitton.name> <83oa1ghirf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="26nmq46gnzphyolq" X-Trace: blaine.gmane.org 1479226304 22886 195.159.176.226 (15 Nov 2016 16:11:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2016 16:11:44 +0000 (UTC) Cc: 24944@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 15 17:11:39 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6gK4-00012d-Uz for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 17:11:01 +0100 Original-Received: from localhost ([::1]:47322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6gK8-0005x8-4o for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 11:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6gGH-0003Lq-Ls for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:07:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6gGD-0000O9-RH for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:07:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42973) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6gGD-0000Nr-OD for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6gGD-0002WP-IY for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 11:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2016 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24944 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24944-submit@debbugs.gnu.org id=B24944.14792259699630 (code B ref 24944); Tue, 15 Nov 2016 16:07:01 +0000 Original-Received: (at 24944) by debbugs.gnu.org; 15 Nov 2016 16:06:09 +0000 Original-Received: from localhost ([127.0.0.1]:58372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6gFN-0002VG-EE for submit@debbugs.gnu.org; Tue, 15 Nov 2016 11:06:09 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6gFL-0002V7-Jr for 24944@debbugs.gnu.org; Tue, 15 Nov 2016 11:06:08 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3CCCE215FC; Tue, 15 Nov 2016 11:06:07 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Tue, 15 Nov 2016 11:06:07 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=spwhitton.name; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=ZA1OZ7A839RAhm4uDwF3sFpoNws=; b=o29cQk W23TEDN1lMaq6bPS8AtTiEAqA9xutQzuy+ycZODMvy41OEQUBltJKGSM+IHMmayl EE+0s8JHYeeZ7R4qqdk2uvqxeOmtkFLV5AT0NNZzlQw/DwoSeo4UNGmSuxgeGH3L y2WrRaslhWG90/qqI8s0YJOF9Vj+FoAH8RKnM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=ZA1OZ7A839RAhm 4uDwF3sFpoNws=; b=q/m38TruZHjHWQgkuc2MT03jwdm9J1FnkmWBTnMpBXeOnN 7Y9lgr77DsEUDlD//zY74h3ER9E/8G2t04s9PhmWFCnpmpUHLlaGeWmitGAvFN1h XfLh3KUmOx41bMGeIJGGhbzWmR/avLSGkThDkry/qBwRNd99Rq5ra6A1h1CKE= X-ME-Sender: X-Sasl-enc: pqtvyHhPlsJXnRrl/oIzEDuaKRFr4Bg7lgLBECDh70WU 1479225966 Content-Disposition: inline In-Reply-To: <83oa1ghirf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125717 Archived-At: --26nmq46gnzphyolq Content-Type: multipart/mixed; boundary="ult6psdbo4ubnhgo" Content-Disposition: inline --ult6psdbo4ubnhgo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2016 at 05:20:36PM +0200, Eli Zaretskii wrote: > A better test is to use fboundp (after requiring the package that > should define it) to probe whether the function exists or not, instead > of relying on the version. Thanks. Improved patch attached. Note that this is against the version of seq in elpa.git, not emacs.git --=20 Sean Whitton --ult6psdbo4ubnhgo Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Skip-test-seq-random-elt-take-all-on-Emacs-24.patch" Content-Transfer-Encoding: quoted-printable =46rom 494e3476538cd2cefdc7343057ccfb33412aca73 Mon Sep 17 00:00:00 2001 =46rom: Sean Whitton Date: Mon, 14 Nov 2016 20:58:14 -0700 Subject: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24 The function `map-length' is not available. --- packages/seq/tests/seq-tests.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/seq/tests/seq-tests.el b/packages/seq/tests/seq-tests= =2Eel index 53930fa..0e15f25 100644 --- a/packages/seq/tests/seq-tests.el +++ b/packages/seq/tests/seq-tests.el @@ -28,6 +28,7 @@ =20 (require 'ert) (require 'seq) +(require 'map) =20 (defmacro with-test-sequences (spec &rest body) "Successively bind VAR to a list, vector, and string built from SEQ. @@ -351,6 +352,7 @@ Evaluate BODY for each created sequence. ["xxx" "xx" "x"])))) =20 (ert-deftest test-seq-random-elt-take-all () + (skip-unless (fboundp 'map-length)) (let ((seq '(a b c d e)) (count '())) (should (=3D 0 (map-length count))) --=20 2.10.2 --ult6psdbo4ubnhgo-- --26nmq46gnzphyolq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYKzJjAAoJEGlbeuS/BmJAdO0P/3t3A/YFpxmE7ah93SjKs7MQ hqXHfv1XE1dhkGGPjg0YzBs26oQie2m55iG3lW+MbJTyxhJCLLzGxB9szgWLlg2w YwpT+UWnl5CP+KVtfkmhvXpdcws5gG6O7crWDU9NlWArYVSABMNL4PcWSOSZX7Eh Zn1Hi6z016YEq3/d/2g/NXy6vW6IQlvi8VXjQnZWQsTEHORTcs+g17QG0Y9zPfNw 7RZCQGRyWvIJAnVHOr0S9NGDurQi3gj8hUA5lU0qVsf0Yo/EDdqlQKsI2Br987sM d9RnPt4ufzlAtJrA9xPu/XUe2LbWPLZJ9AcnLTd6VTf3+Gg+V3B85Tae1TsSVEui n5xCvezuaZR4ZZWwS+QkF1z95wt70fBPn/KKziGQhUjhW/xe6Hjig4plVKz5IERg 1r7+wBVrRfcyt5Za2cqaDfGXnJTQXug+0faCkxS0I1KrQFrFk57jbRjQv4dtbbhC NUtyOXAruy7VZ+T5QK1IerOPzsDvSybePbZGB0+RExSyVqYf+PFK+yXizbo7pZzQ 5QR7c74e1aj0TORQVddlqh+GGQgPmDyPljlIj6KQsgaxnkBGOetCp9KTTKlNyrBP rYctksbIeXUzevpD7NWpeE3FqSKz70eNb2R1IMsPbGREj/eBL1kO/r0O8hhoaLZ7 R1/MpCUK0JAX3MNdo19a =l/zF -----END PGP SIGNATURE----- --26nmq46gnzphyolq--