From: Sean Whitton <spwhitton@spwhitton.name>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24944@debbugs.gnu.org
Subject: bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24
Date: Tue, 15 Nov 2016 09:06:06 -0700 [thread overview]
Message-ID: <20161115160606.autvngpkpxuvbpyv@iris.silentflame.com> (raw)
In-Reply-To: <83oa1ghirf.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 370 bytes --]
On Tue, Nov 15, 2016 at 05:20:36PM +0200, Eli Zaretskii wrote:
> A better test is to use fboundp (after requiring the package that
> should define it) to probe whether the function exists or not, instead
> of relying on the version.
Thanks. Improved patch attached.
Note that this is against the version of seq in elpa.git, not emacs.git
--
Sean Whitton
[-- Attachment #1.2: 0001-Skip-test-seq-random-elt-take-all-on-Emacs-24.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]
From 494e3476538cd2cefdc7343057ccfb33412aca73 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Mon, 14 Nov 2016 20:58:14 -0700
Subject: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24
The function `map-length' is not available.
---
packages/seq/tests/seq-tests.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/packages/seq/tests/seq-tests.el b/packages/seq/tests/seq-tests.el
index 53930fa..0e15f25 100644
--- a/packages/seq/tests/seq-tests.el
+++ b/packages/seq/tests/seq-tests.el
@@ -28,6 +28,7 @@
(require 'ert)
(require 'seq)
+(require 'map)
(defmacro with-test-sequences (spec &rest body)
"Successively bind VAR to a list, vector, and string built from SEQ.
@@ -351,6 +352,7 @@ Evaluate BODY for each created sequence.
["xxx" "xx" "x"]))))
(ert-deftest test-seq-random-elt-take-all ()
+ (skip-unless (fboundp 'map-length))
(let ((seq '(a b c d e))
(count '()))
(should (= 0 (map-length count)))
--
2.10.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-15 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 4:00 bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24 Sean Whitton
2016-11-15 15:20 ` Eli Zaretskii
2016-11-15 16:06 ` Sean Whitton [this message]
2016-11-15 17:02 ` Nicolas Petton
2016-11-15 17:06 ` Sean Whitton
2016-11-15 20:13 ` Nicolas Petton
2016-11-15 22:44 ` Sean Whitton
2016-11-15 22:58 ` Nicolas Petton
2016-11-16 0:30 ` Sean Whitton
2016-11-16 17:40 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115160606.autvngpkpxuvbpyv@iris.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=24944@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.